Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CL-261: update popover styles and fix stories #13547

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

danielleflinn
Copy link
Member

@danielleflinn danielleflinn commented Feb 24, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/CL-261

📔 Objective

Updated the UI styles of the popover to match the new design system styles:

  • increasing the corner radius
  • adding bitTypography for text styles.
  • updating icon button size + alignment with title
  • Fixing broken open to "top" stories; due to not enough top margin, so these are also fixed.
  • Adding Long title story to show text wrapping / title alignment better

📸 Screenshots

See Chromatic

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@danielleflinn danielleflinn requested a review from a team as a code owner February 24, 2025 22:07
@danielleflinn danielleflinn changed the title [CL-261] updated popover styles and fix stories [CL-261] update popover styles and fix stories Feb 24, 2025
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 35.83%. Comparing base (6f2a713) to head (59252b9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
libs/components/src/popover/popover.stories.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13547      +/-   ##
==========================================
- Coverage   35.83%   35.83%   -0.01%     
==========================================
  Files        3167     3167              
  Lines       93407    93410       +3     
  Branches    17001    17001              
==========================================
+ Hits        33471    33472       +1     
- Misses      57344    57346       +2     
  Partials     2592     2592              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielleflinn danielleflinn changed the title [CL-261] update popover styles and fix stories CL-261: update popover styles and fix stories Feb 24, 2025
Copy link
Contributor

github-actions bot commented Feb 24, 2025

Logo
Checkmarx One – Scan Summary & Detailsb94676c2-2ca1-4e34-a2c2-3c6f48b6fa32

Great job, no security vulnerabilities found in this Pull Request

@@ -5,11 +5,12 @@ import { Component, EventEmitter, Input, Output, TemplateRef, ViewChild } from "

import { IconButtonModule } from "../icon-button/icon-button.module";
import { SharedModule } from "../shared/shared.module";
import { TypographyDirective } from "../typography/typography.directive";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, let's change this to

Suggested change
import { TypographyDirective } from "../typography/typography.directive";
import { TypographyModule } from "../typography";

and on line 13.

(check in the code editor before committing that change because I did it from memory lol)

vleague2
vleague2 previously approved these changes Feb 25, 2025
@danielleflinn danielleflinn merged commit e6e6058 into main Feb 25, 2025
95 checks passed
@danielleflinn danielleflinn deleted the CL-261-update-popover-styles branch February 25, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants