-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CL-261: update popover styles and fix stories #13547
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13547 +/- ##
==========================================
- Coverage 35.83% 35.83% -0.01%
==========================================
Files 3167 3167
Lines 93407 93410 +3
Branches 17001 17001
==========================================
+ Hits 33471 33472 +1
- Misses 57344 57346 +2
Partials 2592 2592 ☔ View full report in Codecov by Sentry. |
Great job, no security vulnerabilities found in this Pull Request |
@@ -5,11 +5,12 @@ import { Component, EventEmitter, Input, Output, TemplateRef, ViewChild } from " | |||
|
|||
import { IconButtonModule } from "../icon-button/icon-button.module"; | |||
import { SharedModule } from "../shared/shared.module"; | |||
import { TypographyDirective } from "../typography/typography.directive"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, let's change this to
import { TypographyDirective } from "../typography/typography.directive"; | |
import { TypographyModule } from "../typography"; |
and on line 13.
(check in the code editor before committing that change because I did it from memory lol)
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/CL-261
📔 Objective
Updated the UI styles of the popover to match the new design system styles:
bitTypography
for text styles.📸 Screenshots
See Chromatic
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes