[PM-9126] COM Object Registration #13278
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13278 +/- ##
==========================================
+ Coverage 35.83% 36.24% +0.41%
==========================================
Files 3167 3140 -27
Lines 93407 91528 -1879
Branches 17001 17001
==========================================
- Hits 33471 33175 -296
+ Misses 57344 55761 -1583
Partials 2592 2592 ☔ View full report in Codecov by Sentry. |
dani-garcia
reviewed
Feb 24, 2025
| @@ -1,6 +1,6 @@ | |||
| [workspace] | |||
| resolver = "2" | |||
| members = ["napi", "core", "proxy", "macos_provider", "windows-plugin-authenticator"] | |||
| members = ["napi", "core", "proxy", "macos_provider", "windows_plugin_authenticator"] | |||
There was a problem hiding this comment.
Note that after moving this crate you'd also need to update codeowners:
Line 117 in a9862d2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-9126
📔 Objective
this PR is in progress
Register the Bitwarden Desktop App COM Object with the Windows API so it can be used as a plugin authenticator.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes