Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16662] Fix annual pricing for billable providers #12657

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jonashendrickx
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16662

📔 Objective

  • Fixed label showing 'year' instead of 'month', when the billing cadence was actually annually.
  • Adjusted scopes for fields, methods & properties.

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jonashendrickx jonashendrickx requested a review from a team as a code owner January 2, 2025 16:06
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Logo
Checkmarx One – Scan Summary & Detailsdb476179-316b-43d1-8157-6d4153ba2953

No New Or Fixed Issues Found

@jonashendrickx jonashendrickx enabled auto-merge (squash) January 2, 2025 16:41
auto-merge was automatically disabled January 2, 2025 17:17

Pull request was closed

@jonashendrickx jonashendrickx reopened this Jan 3, 2025
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 33.73%. Comparing base (196c1e1) to head (3c7abe0).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rs/subscription/provider-subscription.component.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12657      +/-   ##
==========================================
- Coverage   33.74%   33.73%   -0.01%     
==========================================
  Files        2918     2918              
  Lines       90994    90998       +4     
  Branches    17200    17202       +2     
==========================================
- Hits        30703    30696       -7     
- Misses      57891    57902      +11     
  Partials     2400     2400              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants