Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13028] - add fixed width to vault list icon #12644

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jaasen-livefront
Copy link
Collaborator

@jaasen-livefront jaasen-livefront commented Dec 31, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13028

📔 Objective

This PR adds a fixed width to the vault icons to account for potentially differing widths between icons which ensures proper alignment.

📸 Screenshots

Before After
Screenshot 2024-12-31 at 3 11 43 PM Screenshot 2024-12-31 at 3 10 55 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jaasen-livefront jaasen-livefront requested a review from a team as a code owner December 31, 2024 23:17
Copy link
Contributor

github-actions bot commented Dec 31, 2024

Logo
Checkmarx One – Scan Summary & Details20e18358-3a5a-419a-89a2-f919352f4cd8

No New Or Fixed Issues Found

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.74%. Comparing base (1e6471b) to head (18a8999).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12644   +/-   ##
=======================================
  Coverage   33.74%   33.74%           
=======================================
  Files        2918     2918           
  Lines       90994    90994           
  Branches    17200    17200           
=======================================
  Hits        30703    30703           
  Misses      57891    57891           
  Partials     2400     2400           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djsmith85 djsmith85 linked an issue Jan 3, 2025 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indentations are inconsistent when using website icons
1 participant