Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused stateService dependency #12167

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

djsmith85
Copy link
Contributor

๐Ÿ“” Objective

While updating a different PR I noticed the unused stateService within some CLI commands. This removes them as a ctor param and dependency.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@djsmith85 djsmith85 requested a review from a team as a code owner November 27, 2024 14:07
@djsmith85 djsmith85 enabled auto-merge (squash) November 27, 2024 14:08
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 33.49%. Comparing base (d5b14d1) to head (2380964).
Report is 1 commits behind head on main.

โœ… All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12167   +/-   ##
=======================================
  Coverage   33.48%   33.49%           
=======================================
  Files        2877     2877           
  Lines       89908    89907    -1     
  Branches    17111    17111           
=======================================
+ Hits        30106    30113    +7     
+ Misses      57423    57415    -8     
  Partials     2379     2379           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant