Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13757] Add policy component form validation to policy edit component #12150

Conversation

BTreston
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13757

📔 Objective

This PR resolves an issue where the Policy Edit component's form validation on the save button is not synced with the validation status of the Policy Component's form group.

📸 Screenshots

Screenshot 2024-11-25 at 1 36 01 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@BTreston BTreston requested a review from a team as a code owner November 25, 2024 18:40
@BTreston BTreston requested a review from JimmyVo16 November 25, 2024 18:40
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details2f93ad6a-6502-4ae7-8851-df58e67bda46

No New Or Fixed Issues Found

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 33.47%. Comparing base (d13bbf9) to head (4dd6ef2).
Report is 52 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...le/organizations/policies/policy-edit.component.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12150      +/-   ##
==========================================
- Coverage   33.47%   33.47%   -0.01%     
==========================================
  Files        2875     2875              
  Lines       89834    89835       +1     
  Branches    17103    17103              
==========================================
  Hits        30073    30073              
- Misses      57385    57386       +1     
  Partials     2376     2376              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JimmyVo16 JimmyVo16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these small PRs; they’re really easy to review.

@BTreston BTreston merged commit 694f2c7 into main Dec 3, 2024
36 checks passed
@BTreston BTreston deleted the ac/pm-13757-policy-edit-component-not-reading-policy-component-form-validation-status branch December 3, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants