[PM-15198] Make trial banner work with Stripe Sources API deprecation flag

[amorask-bitwarden]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15198

📔 Objective

The payment optional trial banner was not checking whether the Stripe Sources API deprecation flag was on in several places, resulting in invocations of the incorrect endpoint to get payment sources. This led to the banner showing for people who had already added a payment method.

📸 Screenshots

Screen.Recording.2024-11-25.at.9.27.35.AM.mov

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 33.47%. Comparing base (f79141c) to head (72014a7).

Files with missing lines	Patch %	Lines
...c/billing/services/organization-billing.service.ts	0.00%	13 Missing ⚠️
...pps/web/src/app/vault/org-vault/vault.component.ts	0.00%	3 Missing ⚠️
...app/secrets-manager/overview/overview.component.ts	0.00%	3 Missing ⚠️
.../src/app/vault/individual-vault/vault.component.ts	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #12146   +/-   ##
=======================================
  Coverage   33.47%   33.47%           
=======================================
  Files        2878     2878           
  Lines       89941    89953   +12     
  Branches    17116    17117    +1     
=======================================
+ Hits        30106    30113    +7     
- Misses      57455    57460    +5     
  Partials     2380     2380           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cyprain-okeke]

Looks good for billing

[github-actions]

Checkmarx One – Scan Summary & Details – 478c4d9e-fa1b-4344-9940-1cc2d61fa267

Fixed Issues

Severity	Issue	Source File / Package
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health-members.component.html: 50
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health-members.component.html: 50
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health-members.component.html: 55
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health-members.component.html: 45
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 40
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 45
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 40
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 35
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health.component.html: 50
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health.component.html: 40
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health.component.html: 45
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health.component.html: 45

[gbubemismith]

Vault changes look good