Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15198] Make trial banner work with Stripe Sources API deprecation flag #12146

Conversation

amorask-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15198

📔 Objective

The payment optional trial banner was not checking whether the Stripe Sources API deprecation flag was on in several places, resulting in invocations of the incorrect endpoint to get payment sources. This led to the banner showing for people who had already added a payment method.

📸 Screenshots

Screen.Recording.2024-11-25.at.9.27.35.AM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 33.51%. Comparing base (3fe11b7) to head (81a2c17).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/billing/services/organization-billing.service.ts 0.00% 13 Missing ⚠️
...pps/web/src/app/vault/org-vault/vault.component.ts 0.00% 3 Missing ⚠️
...app/secrets-manager/overview/overview.component.ts 0.00% 3 Missing ⚠️
.../src/app/vault/individual-vault/vault.component.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12146      +/-   ##
==========================================
- Coverage   33.52%   33.51%   -0.02%     
==========================================
  Files        2884     2884              
  Lines       90106    90118      +12     
  Branches    17135    17136       +1     
==========================================
- Hits        30210    30201       -9     
- Misses      57511    57531      +20     
- Partials     2385     2386       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cyprain-okeke cyprain-okeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for billing

Copy link
Contributor

github-actions bot commented Nov 26, 2024

Logo
Checkmarx One – Scan Summary & Detailsa01cc28a-787e-4038-b9bd-902b5273dd95

No New Or Fixed Issues Found

Copy link
Member

@gbubemismith gbubemismith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vault changes look good

Copy link
Contributor

@mzieniukbw mzieniukbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from SM side

@amorask-bitwarden amorask-bitwarden merged commit 0544100 into main Dec 2, 2024
60 of 62 checks passed
@amorask-bitwarden amorask-bitwarden deleted the billing/PM-15198/payment-optional-trial-banner-with-sources-deprecation branch December 2, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants