-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-15198] Make trial banner work with Stripe Sources API deprecation flag #12146
[PM-15198] Make trial banner work with Stripe Sources API deprecation flag #12146
Conversation
…er-with-sources-deprecation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12146 +/- ##
==========================================
- Coverage 33.52% 33.51% -0.02%
==========================================
Files 2884 2884
Lines 90106 90118 +12
Branches 17135 17136 +1
==========================================
- Hits 30210 30201 -9
- Misses 57511 57531 +20
- Partials 2385 2386 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for billing
…er-with-sources-deprecation
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vault changes look good
…er-with-sources-deprecation
…er-with-sources-deprecation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from SM side
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15198
📔 Objective
The payment optional trial banner was not checking whether the Stripe Sources API deprecation flag was on in several places, resulting in invocations of the incorrect endpoint to get payment sources. This led to the banner showing for people who had already added a payment method.
📸 Screenshots
Screen.Recording.2024-11-25.at.9.27.35.AM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes