[PM-13999] Show estimated tax for taxable countries #12145

jonashendrickx · 2024-11-25T14:06:51Z

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13999

📔 Objective

Use Stripe for the sales tax estimation using the customer's tax id, postal code and country.
Display any errors returned by the backend
Restore and display any previously saved tax information or billing information.
Supports the AC-2476-deprecate-stripe-sources-api feature flag in both enabled/disabled state.
Removed duplicate sections related to updating tax information or billing information
Ability to enter tax information for consumers in individual plans.

📸 Screenshots

Bot postal code & country fields are required. Note that the checkbox to include a tax id is removed.

It also listens for additional fields, such as plan, billing interval, additional storage, additional seats, machine accounts, etc.

Tax id codes are validated by our backend using regular expressions to resolve the tax id type based on the selected country:

Error messages by Stripe are also handled now, example is not available.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

…r-Clients' into PM-14892-Sales-Tax-Estimation-For-Clients

…9-Show-estimated-tax-for-taxable-countries

…M-13999-Show-estimated-tax-for-taxable-countries

codecov · 2024-11-25T14:18:05Z

Codecov Report

Attention: Patch coverage is 6.41892% with 277 lines in your changes missing coverage. Please review.

Project coverage is 33.83%. Comparing base (3db5bea) to head (3f8e14e).
Report is 56 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...s/web/src/app/billing/shared/tax-info.component.ts	7.40%	50 Missing ⚠️
...ling/organizations/organization-plans.component.ts	0.00%	46 Missing ⚠️
...ax-information/manage-tax-information.component.ts	7.69%	35 Missing and 1 partial ⚠️
...ling/organizations/change-plan-dialog.component.ts	0.00%	35 Missing ⚠️
...yment-dialog/adjust-payment-dialog-v2.component.ts	25.92%	19 Missing and 1 partial ⚠️
...-payment-dialog/adjust-payment-dialog.component.ts	18.18%	18 Missing ⚠️
...pp/billing/individual/premium/premium.component.ts	0.00%	15 Missing ⚠️
...billing/individual/premium/premium-v2.component.ts	0.00%	13 Missing ⚠️
...c/billing/models/response/tax-id-types.response.ts	0.00%	13 Missing ⚠️
libs/common/src/billing/services/tax.service.ts	0.00%	10 Missing ⚠️
... and 8 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12145      +/-   ##
==========================================
+ Coverage   33.48%   33.83%   +0.34%     
==========================================
  Files        2877     2892      +15     
  Lines       89902    91668    +1766     
  Branches    17109    17697     +588     
==========================================
+ Hits        30104    31015     +911     
- Misses      57419    58236     +817     
- Partials     2379     2417      +38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

apps/web/src/app/billing/individual/premium/premium-v2.component.html

cyprain-okeke · 2024-11-26T10:40:21Z

apps/web/src/app/billing/individual/premium/premium-v2.component.ts

+      .then((invoice) => {
+        this.estimatedTax = invoice.taxAmount;
+      })
+      .catch((error) => {


Consider extracting the error handling logic into a separate method. This keeps your main logic clear and makes it easier to manage errors

I usually keep them inline unless I need to reference the code elsewhere.

cyprain-okeke · 2024-11-26T10:41:02Z

apps/web/src/app/billing/individual/premium/premium-v2.component.ts

+    if (!this.taxInfoComponent.country || !this.taxInfoComponent.postalCode) {
+      return;
+    }
+    const request: PreviewIndividualInvoiceRequest = {


If previewIndividualInvoice returns a promise, using async/await can improve readability and eliminate the need for .then() and .catch() chaining

I had looked into that, but then I get a linting error: Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the void operator where I am subscribing to value changes calling refreshSalesTax().

cyprain-okeke · 2024-11-26T10:43:49Z

apps/web/src/app/billing/shared/payment-method.component.ts

+          message: this.i18nService.t("taxInfoUpdated"),
+        });
+      })
+      .catch((error) => {


Instead of mixing async/await with .then() and .catch(), use async/await consistently to improve readability and also consider extracting the error

cyprain-okeke · 2024-11-26T10:47:02Z

apps/web/src/app/billing/organizations/organization-plans.component.ts

+        this.total = invoice.totalAmount;
+      })
+      .catch((error) => {
+        this.toastService.showToast({


Consider centralizing the error handling logic for better maintainability

…tries

This reverts commit f0413bd.

…en it opens.

github-actions · 2024-12-02T14:22:10Z

Checkmarx One – Scan Summary & Details – 34662c04-c162-417c-8c13-257f2cd3a280

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Client_JQuery_Deprecated_Symbols	/apps/cli/src/service-container/service-container.ts: 876	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health-members.component.html: 50
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health-members.component.html: 45
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health-members.component.html: 50
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health-members.component.html: 55
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 45
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 40
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 35
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 40
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health.component.html: 45
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health.component.html: 45
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health.component.html: 50
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/tools/access-intelligence/password-health.component.html: 40
	Client_DOM_Open_Redirect	/apps/web/src/app/billing/organizations/payment-method/organization-payment-method.component.ts: 145
	Client_DOM_Open_Redirect	/apps/web/src/app/billing/organizations/payment-method/organization-payment-method.component.ts: 175
	Client_DOM_Open_Redirect	/apps/web/src/app/billing/shared/payment-method.component.ts: 147
	Client_DOM_Open_Redirect	/apps/web/src/app/billing/shared/payment-method.component.ts: 173

This reverts commit 1dce7f5.

…#12244) This reverts commit 1dce7f5.

jonashendrickx and others added 17 commits November 14, 2024 13:28

[PM-14892] Refactoring tax estimation

1661320

[PM-14892] Refactoring tax estimation

52e7c26

wip

d786f50

wip

bfafdf7

format

a125a8f

useless code

fe2564a

Don't reset to 0 upon error

2af08b8

Merge branch 'main' into PM-14892-Sales-Tax-Estimation-For-Clients

017017f

REFACTOR

2117d52

Merge remote-tracking branch 'origin/PM-14892-Sales-Tax-Estimation-Fo…

f1368cd

…r-Clients' into PM-14892-Sales-Tax-Estimation-For-Clients

Working for org creation

6c28363

Merge branch 'main' into PM-14891-Sales-Tax-Estimation-For-Organizations

12a0382

wip

4b264b6

Merge branch 'main' into PM-14892-Sales-Tax-Estimation-For-Clients

0014c22

for old premium component

2588716

Merge branch 'PM-14892-Sales-Tax-Estimation-For-Clients' into PM-1399…

51ebe41

…9-Show-estimated-tax-for-taxable-countries

Merge branch 'PM-14891-Sales-Tax-Estimation-For-Organizations' into P…

6b97fb0

…M-13999-Show-estimated-tax-for-taxable-countries

jonashendrickx requested a review from a team as a code owner November 25, 2024 14:06

jonashendrickx added 4 commits November 25, 2024 15:23

refactor

0aa90e1

refactor

fd9ec3f

fix english translation tax id number

81b7664

refactor

7a2e59b

jonashendrickx requested a review from a team as a code owner November 26, 2024 10:30

jonashendrickx requested a review from JimmyVo16 November 26, 2024 10:30

jonashendrickx added 3 commits November 26, 2024 11:34

refactor

63f85c7

refactor

a1ed915

refactor

f443708

cyprain-okeke reviewed Nov 26, 2024

View reviewed changes

refactor

4c5e734

jonashendrickx added 10 commits November 26, 2024 12:51

revert translation renaming

d2425ae

rename callback

44c3bed

Merge branch 'main' into PM-13999-Show-estimated-tax-for-taxable-coun…

6babfcd

…tries

not correctly calculating total

83c3b7c

reorder

3957a6c

remove

f0413bd

Revert "remove"

974e070

This reverts commit f0413bd.

remove duplicate section

0bcda6e

ChangePlanDialog now properly supports the sales tax being updated wh…

e3a4baa

…en it opens.

load state of adjust payment dialog

4dcb295

jonashendrickx added 3 commits December 3, 2024 06:48

f

d46cdf9

f

5313b3f

f

3f8e14e

cturnbull-bitwarden approved these changes Dec 3, 2024

View reviewed changes

eliykat approved these changes Dec 4, 2024

View reviewed changes

jonashendrickx merged commit 1dce7f5 into main Dec 4, 2024
72 of 73 checks passed

jonashendrickx deleted the PM-13999-Show-estimated-tax-for-taxable-countries branch December 4, 2024 10:45

jonashendrickx restored the PM-13999-Show-estimated-tax-for-taxable-countries branch December 4, 2024 14:30

jonashendrickx added a commit that referenced this pull request Dec 4, 2024

Revert "[PM-13999] Show estimated tax for taxable countries (#12145)"

5ab86d7

This reverts commit 1dce7f5.

jonashendrickx mentioned this pull request Dec 4, 2024

Revert "[PM-13999] Show estimated tax for taxable countries" #12244

Merged

jonashendrickx added a commit that referenced this pull request Dec 4, 2024

Revert "[PM-13999] Show estimated tax for taxable countries (#12145)" (…

b25dc63

…#12244) This reverts commit 1dce7f5.

vincentsalucci mentioned this pull request Dec 4, 2024

[PM-13999] show estimated tax for taxable countries #12245

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PM-13999] Show estimated tax for taxable countries #12145

[PM-13999] Show estimated tax for taxable countries #12145

jonashendrickx commented Nov 25, 2024 •

edited

Loading

codecov bot commented Nov 25, 2024 •

edited

Loading

cyprain-okeke Nov 26, 2024

jonashendrickx Dec 2, 2024

cyprain-okeke Nov 26, 2024

jonashendrickx Dec 2, 2024

cyprain-okeke Nov 26, 2024

cyprain-okeke Nov 26, 2024

github-actions bot commented Dec 2, 2024 •

edited

Loading

[PM-13999] Show estimated tax for taxable countries #12145

[PM-13999] Show estimated tax for taxable countries #12145

Conversation

jonashendrickx commented Nov 25, 2024 • edited Loading

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

🦮 Reviewer guidelines

codecov bot commented Nov 25, 2024 • edited Loading

Codecov Report

cyprain-okeke Nov 26, 2024

Choose a reason for hiding this comment

jonashendrickx Dec 2, 2024

Choose a reason for hiding this comment

cyprain-okeke Nov 26, 2024

Choose a reason for hiding this comment

jonashendrickx Dec 2, 2024

Choose a reason for hiding this comment

cyprain-okeke Nov 26, 2024

Choose a reason for hiding this comment

cyprain-okeke Nov 26, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 2, 2024 • edited Loading

New Issues

Fixed Issues

jonashendrickx commented Nov 25, 2024 •

edited

Loading

codecov bot commented Nov 25, 2024 •

edited

Loading

github-actions bot commented Dec 2, 2024 •

edited

Loading