Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11948] Hide Open At Login Option On Windows Store Installs #12112

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

justindbaur
Copy link
Member

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

The open on login option does not currently work for Microsoft Store installed apps. So we are going to hide the option until electron/electron#42016 becomes resolved.

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@justindbaur justindbaur requested review from a team and dani-garcia November 22, 2024 20:04
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.46%. Comparing base (04caec6) to head (1774d74).
Report is 238 commits behind head on main.

โœ… All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...pps/desktop/src/app/accounts/settings.component.ts 0.00% 2 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12112      +/-   ##
==========================================
- Coverage   33.46%   33.46%   -0.01%     
==========================================
  Files        2874     2874              
  Lines       89843    89845       +2     
  Branches    17106    17106              
==========================================
  Hits        30068    30068              
- Misses      57399    57401       +2     
  Partials     2376     2376              

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@justindbaur justindbaur merged commit b3155d1 into main Dec 26, 2024
37 of 38 checks passed
@justindbaur justindbaur deleted the ps/pm-11948/hide-open-at-login branch December 26, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants