Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-15070 Star critical apps #12109

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

voommen-livefront
Copy link
Collaborator

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-15070

๐Ÿ“” Objective

When a record is flagged - then show a "start" next to it rather than a checkbox

๐Ÿ“ธ Screenshots

image

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@voommen-livefront voommen-livefront requested a review from a team as a code owner November 22, 2024 18:02
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 80.35714% with 11 lines in your changes missing coverage. Please review.

Project coverage is 33.49%. Comparing base (2185559) to head (522611c).
Report is 33 commits behind head on main.

โœ… All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ols/access-intelligence/risk-insights.component.ts 0.00% 6 Missing โš ๏ธ
...isk-insights/services/critical-apps-api.service.ts 90.90% 1 Missing and 2 partials โš ๏ธ
.../access-intelligence/all-applications.component.ts 93.75% 1 Missing โš ๏ธ
.../src/tools/reports/risk-insights/services/index.ts 0.00% 1 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12109      +/-   ##
==========================================
+ Coverage   33.48%   33.49%   +0.01%     
==========================================
  Files        2855     2872      +17     
  Lines       89360    89873     +513     
  Branches    17016    17109      +93     
==========================================
+ Hits        29921    30107     +186     
- Misses      57082    57393     +311     
- Partials     2357     2373      +16     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.


๐Ÿšจ Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant