-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-15061] extract encryptors from generator service #12068
[PM-15061] extract encryptors from generator service #12068
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12068 +/- ##
==========================================
+ Coverage 33.47% 33.53% +0.05%
==========================================
Files 2878 2882 +4
Lines 89941 90022 +81
Branches 17116 17125 +9
==========================================
+ Hits 30106 30186 +80
- Misses 57455 57456 +1
Partials 2380 2380 ☔ View full report in Codecov by Sentry. |
libs/common/src/tools/cryptography/organization-encryptor.abstraction.ts
Outdated
Show resolved
Hide resolved
libs/common/src/tools/cryptography/organization-key-encryptor.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@audreyality Just some documentation updates and thank you for answering any questions I had offline.
libs/common/src/tools/cryptography/organization-key-encryptor.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15061
📔 Objective
Extract encryptors from generator service so they can be reused across the tools codebase.
🦖 System Evolution
A new set of encryptors that distinguishes key slots from key instances is in the works. These encryptors also have specialized key rotation interfaces to enable integration with key services.
This PR introduces a parallel set of interfaces (
LegacyEncryptorProvider
et. al.) as a step towards that new system. Like the legacy generator services before it, the legacy encryptor interfaces arrive deprecated so that the impact of importing them is clear--porting to the new interfaces will be required once they become available.🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes