Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-8114] all clients UI refresh SSO component #12061

Merged
merged 92 commits into from
Dec 12, 2024

Conversation

alec-livefront
Copy link
Collaborator

@alec-livefront alec-livefront commented Nov 20, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-8114?atlOrigin=eyJpIjoiNDhjZTM5Y2QwNWZiNGI3Nzk3ZmZhNzY3N2Y4NzRjOWQiLCJwIjoiaiJ9

📔 Objective

Update SSO Component with new logo and text. Consolidate logic into client-specific services.

📸 Screenshots

Web

GMT20241205-170424_Clip_Alec.Rippberger.s.Clip.12_05_2024.mp4

Desktop

GMT20241120-193337_Clip_Alec.Rippberger.s.Clip.11_20_2024.mp4

Browser

GMT20241120-193229_Clip_Alec.Rippberger.s.Clip.11_20_2024.mp4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@alec-livefront alec-livefront changed the title Auth/pm 8114/all clients UI refresh sso component [PM-8114] all clients UI refresh SSO component Nov 20, 2024
@alec-livefront alec-livefront marked this pull request as ready for review November 20, 2024 15:16
@alec-livefront alec-livefront requested review from a team as code owners November 20, 2024 15:16
@alec-livefront alec-livefront marked this pull request as draft November 20, 2024 15:55
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 7.49064% with 247 lines in your changes missing coverage. Please review.

Project coverage is 33.34%. Comparing base (8dd904f) to head (d668857).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
libs/auth/src/angular/sso/sso.component.ts 0.00% 221 Missing ⚠️
...uth/popup/login/extension-sso-component.service.ts 73.33% 0 Missing and 4 partials ⚠️
libs/auth/src/angular/index.ts 0.00% 3 Missing ⚠️
...gular/anon-layout/anon-layout-wrapper.component.ts 0.00% 2 Missing ⚠️
...uth/src/angular/anon-layout/anon-layout.stories.ts 0.00% 2 Missing ⚠️
libs/auth/src/angular/icons/sso-key.icon.ts 0.00% 2 Missing ⚠️
apps/browser/src/auth/popup/sso-v1.component.ts 0.00% 1 Missing ⚠️
apps/browser/src/popup/app-routing.module.ts 0.00% 1 Missing ⚠️
apps/browser/src/popup/app.module.ts 0.00% 1 Missing ⚠️
apps/browser/src/popup/services/services.module.ts 0.00% 1 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12061      +/-   ##
==========================================
- Coverage   33.42%   33.34%   -0.08%     
==========================================
  Files        2901     2907       +6     
  Lines       90567    90825     +258     
  Branches    17213    17295      +82     
==========================================
+ Hits        30272    30290      +18     
- Misses      57900    58135     +235     
- Partials     2395     2400       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alec-livefront alec-livefront marked this pull request as ready for review November 20, 2024 21:16
Copy link
Contributor

@coroiu coroiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems you have some build issues :)

@alec-livefront alec-livefront requested a review from a team as a code owner December 11, 2024 20:44
@JaredSnider-Bitwarden JaredSnider-Bitwarden removed the request for review from a team December 12, 2024 00:12
Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your excellent work on this!

@alec-livefront alec-livefront merged commit 0df7b53 into main Dec 12, 2024
72 checks passed
@alec-livefront alec-livefront deleted the auth/pm-8114/all-clients-ui-refresh-sso-component branch December 12, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants