-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-8114] all clients UI refresh SSO component #12061
[PM-8114] all clients UI refresh SSO component #12061
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12061 +/- ##
==========================================
- Coverage 33.42% 33.34% -0.08%
==========================================
Files 2901 2907 +6
Lines 90567 90825 +258
Branches 17213 17295 +82
==========================================
+ Hits 30272 30290 +18
- Misses 57900 58135 +235
- Partials 2395 2400 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems you have some build issues :)
bitwarden_license/bit-web/src/app/admin-console/providers/clients/vnext-clients.component.ts
Outdated
Show resolved
Hide resolved
…y as it doesn't appear to be necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your excellent work on this!
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8114?atlOrigin=eyJpIjoiNDhjZTM5Y2QwNWZiNGI3Nzk3ZmZhNzY3N2Y4NzRjOWQiLCJwIjoiaiJ9
📔 Objective
Update SSO Component with new logo and text. Consolidate logic into client-specific services.
📸 Screenshots
Web
GMT20241205-170424_Clip_Alec.Rippberger.s.Clip.12_05_2024.mp4
Desktop
GMT20241120-193337_Clip_Alec.Rippberger.s.Clip.11_20_2024.mp4
Browser
GMT20241120-193229_Clip_Alec.Rippberger.s.Clip.11_20_2024.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes