Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-5550 Implement on-page autofil for single line TOTP #12058

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

dan-livefront
Copy link
Collaborator

@dan-livefront dan-livefront commented Nov 19, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-5550

📔 Objective

Drafting PR, still in works and may refactor initial approach.

pending items as of now:

🟡 write tests

📸 Screenshots

Screenshot 2024-11-19 at 3 37 49 PM Screenshot 2024-11-19 at 3 37 55 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

-Edit tests
-Clean up styling
-New method to validate totpfields
@dan-livefront dan-livefront self-assigned this Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 75.38462% with 16 lines in your changes missing coverage. Please review.

Project coverage is 33.50%. Comparing base (7d6da0a) to head (48a8b7e).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...wser/src/autofill/background/overlay.background.ts 35.71% 4 Missing and 5 partials ⚠️
...nline-menu/pages/list/autofill-inline-menu-list.ts 84.78% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12058      +/-   ##
==========================================
+ Coverage   33.47%   33.50%   +0.02%     
==========================================
  Files        2878     2878              
  Lines       89941    90002      +61     
  Branches    17116    17128      +12     
==========================================
+ Hits        30106    30151      +45     
- Misses      57455    57463       +8     
- Partials     2380     2388       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant