[PM-14863] Force unlock when keys are cleared / on first unlock and fix account switching behavior

[quexten]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14863

📔 Objective

The intended behavior is that:

• When switching accounts, public keys are cleared from the agent, listing keys should force an unlock (even if the user has no keys, which we cannot know at that point)
• When first starting the app, same as above
• When locking your account, but not switching, public keys should still be listed

📸 Screenshots

Screen.Recording.2024-11-14.at.14.43.19.mov

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.

Project coverage is 33.52%. Comparing base (36750b3) to head (b28ee8d).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...desktop/src/platform/services/ssh-agent.service.ts	0.00%	29 Missing ⚠️
...esktop/src/platform/main/main-ssh-agent.service.ts	0.00%	4 Missing ⚠️
apps/desktop/src/platform/preload.ts	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11994      +/-   ##
==========================================
- Coverage   33.53%   33.52%   -0.02%     
==========================================
  Files        2884     2884              
  Lines       90079    90106      +27     
  Branches    17132    17135       +3     
==========================================
  Hits        30208    30208              
- Misses      57485    57512      +27     
  Partials     2386     2386              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – f3b6286d-0b7d-4ca5-a108-b4a62fa862f5

No New Or Fixed Issues Found

[coroiu]

issue: I might be misunderstanding how this works, but my first thought is that we should use a proper message variable or message type to indicate this and not add hidden meaning to unrelated

[quexten]

Yeah that makes sense. We are extending this for other information aswell (information about the ssh request in the future, and process information in #12065) so we need to extend this either way.

[quexten]

6435845

[coroiu]

Nice! I get the feeling that we're gonna need to take a proper look at how to consolidate this with passkeys, but not in this PR :)

[coroiu]

Nice! I get the feeling that we're gonna need to take a proper look at how to consolidate this with passkeys, but not in this PR :)

[coroiu]

Just ping me again when you've resolved the conflict 👍