[PM-4816] Create shared LoginApprovalComponent

[alec-livefront]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-4816?atlOrigin=eyJpIjoiMzE0Yjg5YjFhYTViNGY0M2E4M2YyY2MyNjg3YTFhMWYiLCJwIjoiaiJ9

📔 Objective

Moves the LoginApprovalComponent to libs/auth and moves desktop-specific logic to a service.

📸 Screenshots

GMT20241115-200832_Clip_Alec.Rippberger.s.Clip.11_15_2024.mp4

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – dc3bb372-8902-4b6f-8cb2-935613a23851

Fixed Issues

Severity	Issue	Source File / Package
	Client_JQuery_Deprecated_Symbols	/libs/importer/src/services/import.service.ts: 467

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 33.55%. Comparing base (0308e6e) to head (9735ee6).
Report is 59 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
libs/auth/src/angular/index.ts	0.00%	2 Missing ⚠️
apps/desktop/src/app/app.component.ts	0.00%	1 Missing ⚠️
apps/desktop/src/app/services/services.module.ts	0.00%	1 Missing ⚠️
.../login/desktop-login-approval-component.service.ts	88.88%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11982      +/-   ##
==========================================
+ Coverage   33.48%   33.55%   +0.06%     
==========================================
  Files        2846     2849       +3     
  Lines       89196    89210      +14     
  Branches    17002    17003       +1     
==========================================
+ Hits        29867    29930      +63     
+ Misses      56976    56913      -63     
- Partials     2353     2367      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• JS Bundle Analysis - Avoid shipping oversized bundles

[JaredSnider-Bitwarden]

Great start on this! Some feedback below:

[micahblut]

@alec-livefront I notice this doesn't show the environment the request is coming from like the design does. It also looks like the spacing between "login attempt by" and "fingerprint phrase" is off. Finally, could you send me a screenshot with the updated styles?

[JaredSnider-Bitwarden]

LGTM! Nice testing work as well!

[alec-livefront]

@micahblut the original screenshot didn't have the correct spacing - I've updated with a screen recording which should show the correct spacing now. Could you elaborate on the environment? I'm not sure I see that in the screenshot attached to the ticket/