Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14525] remove member access feature flag #11972

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

ttalty
Copy link
Contributor

@ttalty ttalty commented Nov 12, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14525

📔 Objective

Removing the member access feature flag from the client and the associated logic.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@ttalty ttalty added the needs-qa Marks a PR as requiring QA approval label Nov 12, 2024
@ttalty ttalty self-assigned this Nov 12, 2024
@ttalty ttalty marked this pull request as ready for review November 12, 2024 18:28
@ttalty ttalty requested a review from a team as a code owner November 12, 2024 18:28
@ttalty ttalty requested a review from BTreston November 12, 2024 18:28
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.48%. Comparing base (350a856) to head (c60716d).
Report is 113 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../organizations/reporting/reports-home.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11972      +/-   ##
==========================================
- Coverage   33.62%   33.48%   -0.14%     
==========================================
  Files        2821     2844      +23     
  Lines       88126    89035     +909     
  Branches    16787    16979     +192     
==========================================
+ Hits        29629    29814     +185     
- Misses      56177    56881     +704     
- Partials     2320     2340      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ttalty ttalty removed the needs-qa Marks a PR as requiring QA approval label Nov 18, 2024
@ttalty ttalty merged commit f1538e1 into main Nov 18, 2024
87 of 89 checks passed
@ttalty ttalty deleted the tools/pm-14525/remove-member-access-feature-flag branch November 18, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants