Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorder address field identification #11824

Merged

Conversation

evan-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11605

📔 Objective

  • fix multi-line autofill to only use single line values when appropriate

📸 Screenshots

Screenshot 2024-11-01 at 10 41 44 AM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@evan-livefront evan-livefront requested a review from a team as a code owner November 1, 2024 15:43
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.41%. Comparing base (5592d64) to head (e7c5243).
Report is 38 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11824   +/-   ##
=======================================
  Coverage   33.41%   33.41%           
=======================================
  Files        2841     2841           
  Lines       89008    89008           
  Branches    16979    16979           
=======================================
  Hits        29744    29744           
  Misses      56927    56927           
  Partials     2337     2337           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cagonzalezcs cagonzalezcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let Jon provide the final approval on this one, but it feels like this would be the right call to make....

@differsthecat differsthecat linked an issue Nov 1, 2024 that may be closed by this pull request
1 task
@evan-livefront
Copy link
Collaborator Author

I'll let Jon provide the final approval on this one, but it feels like this would be the right call to make....

Yeah It allows for the combined "Address" to function more like a fallback than a filter.

@jprusik
Copy link
Contributor

jprusik commented Nov 7, 2024

Copy link
Contributor

github-actions bot commented Nov 11, 2024

Logo
Checkmarx One – Scan Summary & Details4a6c2ff7-333b-46ca-a00e-dc2d9a598a6e

No New Or Fixed Issues Found

@jprusik jprusik added needs-qa Marks a PR as requiring QA approval and removed needs-qa Marks a PR as requiring QA approval labels Nov 14, 2024
@jprusik
Copy link
Contributor

jprusik commented Nov 14, 2024

QA complete/passed

@jprusik jprusik self-assigned this Nov 14, 2024
@jprusik jprusik merged commit c1302a3 into main Nov 14, 2024
29 of 30 checks passed
@jprusik jprusik deleted the autofill/PM-11605-fix-autofill-multi-line-street-address branch November 14, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autofill multi-line street address mishandled
4 participants