-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reorder address field identification #11824
reorder address field identification #11824
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11824 +/- ##
=======================================
Coverage 33.41% 33.41%
=======================================
Files 2841 2841
Lines 89008 89008
Branches 16979 16979
=======================================
Hits 29744 29744
Misses 56927 56927
Partials 2337 2337 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let Jon provide the final approval on this one, but it feels like this would be the right call to make....
Yeah It allows for the combined "Address" to function more like a fallback than a filter. |
No New Or Fixed Issues Found |
QA complete/passed |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11605
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes