-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-11777] fix: TOTP not copied when autofilling passkey #11814
[PM-11777] fix: TOTP not copied when autofilling passkey #11814
Conversation
- Added totpService to overlay background constructor - Edited spec to account for totpsService - Edited fillInlineMenuCipher to copy totp to clipboard if present
…hen-autofilling-passkey
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #11814 +/- ##
=======================================
Coverage 33.52% 33.52%
=======================================
Files 2815 2815
Lines 87540 87543 +3
Branches 16689 16690 +1
=======================================
+ Hits 29349 29351 +2
Misses 55883 55883
- Partials 2308 2309 +1 ☔ View full report in Codecov by Sentry. |
…hen-autofilling-passkey
…hen-autofilling-passkey
…hen-autofilling-passkey
…hen-autofilling-passkey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11777
📔 Objective
When utilizing the inline menu to authenticate with a passkey, the TOTP is currently not copied to over to the clipboard.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes