Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11777] fix: TOTP not copied when autofilling passkey #11814

Conversation

dan-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11777

📔 Objective

When utilizing the inline menu to authenticate with a passkey, the TOTP is currently not copied to over to the clipboard.

  • Added totpService to overlay background constructor
  • Edited spec to account for totpsService
  • Edited fillInlineMenuCipher to copy totp to clipboard if present

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

- Added totpService to overlay background constructor
- Edited spec to account for totpsService
- Edited fillInlineMenuCipher to copy totp to clipboard if present
@dan-livefront dan-livefront self-assigned this Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.52%. Comparing base (2e6ed4a) to head (5b3d977).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...wser/src/autofill/background/overlay.background.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11814   +/-   ##
=======================================
  Coverage   33.52%   33.52%           
=======================================
  Files        2815     2815           
  Lines       87540    87543    +3     
  Branches    16689    16690    +1     
=======================================
+ Hits        29349    29351    +2     
  Misses      55883    55883           
- Partials     2308     2309    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dan-livefront dan-livefront marked this pull request as ready for review November 1, 2024 15:26
@dan-livefront dan-livefront requested a review from a team as a code owner November 1, 2024 15:26
Copy link
Collaborator

@evan-livefront evan-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dan-livefront dan-livefront merged commit f43bf48 into main Nov 4, 2024
26 checks passed
@dan-livefront dan-livefront deleted the PM-11777-browser-extension-totp-not-copied-when-autofilling-passkey branch November 4, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants