Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13858] fix TOTP fills every input box/field individually #11630

Merged

Conversation

FlorianLang06
Copy link
Contributor

@FlorianLang06 FlorianLang06 commented Oct 19, 2024

🎟️ Tracking

Fixes #11076

📔 Objective

The totp autofill filled on a site with one field per totp digit every field with the entire code. I changed it if the number of totp fields is equal to the length of the totp, every field is filled with only one digit

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@FlorianLang06 FlorianLang06 requested a review from a team as a code owner October 19, 2024 09:46
@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-13858

@bitwarden-bot bitwarden-bot changed the title fix TOTP fills every input box/field individually [PM-13858] fix TOTP fills every input box/field individually Oct 19, 2024
@jprusik jprusik self-assigned this Oct 21, 2024
Copy link
Contributor

@jprusik jprusik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @FlorianLang06 !

I've tested and approved this change, and it solves the issue nicely - I'll be passing this to our QA team for testing next. Once that is completed successfully, we'll be able to merge!

@jprusik jprusik added the needs-qa Marks a PR as requiring QA approval label Oct 22, 2024
@jprusik jprusik removed the needs-qa Marks a PR as requiring QA approval label Oct 30, 2024
@jprusik jprusik merged commit 690e175 into bitwarden:main Oct 30, 2024
66 of 73 checks passed
@jprusik
Copy link
Contributor

jprusik commented Oct 30, 2024

These changes have passed QA, been merged to main branch, and will be included in the next release!

Thanks again for your contribution, @FlorianLang06 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firefox Addon TOTP fills every input box/field individually (example PayPal)
3 participants