[PM-12989] Create process for qa to build client with particular sdk version #11601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Client$` function
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11601 +/- ##
==========================================
- Coverage 33.48% 33.47% -0.01%
==========================================
Files 2851 2854 +3
Lines 89283 89335 +52
Branches 17008 17012 +4
==========================================
+ Hits 29900 29909 +9
- Misses 57029 57071 +42
- Partials 2354 2355 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
New Issues
Fixed Issues
|
coroiu
force-pushed
the
PM-12989-create-process-for-qa-to-build-client-with-particular-sdk-version
branch
2 times, most recently
from
0993fe9
to
d07fe7c
Compare
coroiu
force-pushed
the
PM-12989-create-process-for-qa-to-build-client-with-particular-sdk-version
branch
from
d07fe7c
to
276da3e
Compare
michalchecinski
requested changes
Oct 17, 2024
michalchecinski
previously approved these changes
Oct 17, 2024
Base automatically changed from
PM-11764-implement-account-switching-and-sdk-initialization
to
main
October 18, 2024 14:15
audreyality
previously approved these changes
Oct 29, 2024
1 task
justindbaur
requested changes
Oct 30, 2024
…nt-with-particular-sdk-version
justindbaur
previously approved these changes
Nov 4, 2024
…nt-with-particular-sdk-version
justindbaur
previously approved these changes
Nov 5, 2024
audreyality
reviewed
Nov 7, 2024
audreyality
previously approved these changes
Nov 7, 2024
…nt-with-particular-sdk-version
audreyality
approved these changes
Nov 15, 2024
…nt-with-particular-sdk-version
justindbaur
approved these changes
Nov 19, 2024
coroiu
deleted the
PM-12989-create-process-for-qa-to-build-client-with-particular-sdk-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
Depends on bitwarden/sdk-internal#5
📔 Objective
This PR adds two things:
SDK version string
All clients now provide some way of displaying the underlying SDK version
Help -> About BitwardenSettings -> About -> About Bitwardenbw --versionawait __version()in the consoleCI version override
Users can now trigger manual CI build with an optional SDK branch override. This override will download the latest successful SDK build for that branch and use it to build the client.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes