Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13687] Update search state to show contextually relevant no results view messages #11570

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

jprusik
Copy link
Contributor

@jprusik jprusik commented Oct 15, 2024

🎟️ Tracking

PM-13687

📔 Objective

Note: follow up from PM-12368

When a user registers a new passkey via the extension popup and no login ciphers exist in the vault for that page, show a "No matching logins for this site" message with a search bar and button to save passkey as a new login. If the user searches from this view (or another view) and there are no login cipher matches for the search, display a "No items match your search" message with a button to clear search.

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jprusik jprusik self-assigned this Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 33.15%. Comparing base (70d83fe) to head (3d1f9e4).
Report is 46 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rowser/src/autofill/popup/fido2/fido2.component.ts 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11570      +/-   ##
==========================================
- Coverage   33.16%   33.15%   -0.01%     
==========================================
  Files        2779     2779              
  Lines       86310    86314       +4     
  Branches    16445    16445              
==========================================
- Hits        28621    28614       -7     
- Misses      55415    55426      +11     
  Partials     2274     2274              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jprusik jprusik changed the title update search state to show contextual no results view messages [PM-12368] Update search state to show contextually relevant no results view messages Oct 15, 2024
@jprusik jprusik changed the title [PM-12368] Update search state to show contextually relevant no results view messages [PM-13687] Update search state to show contextually relevant no results view messages Oct 15, 2024
@jprusik jprusik marked this pull request as ready for review October 15, 2024 20:40
@jprusik jprusik requested a review from a team as a code owner October 15, 2024 20:40
Copy link
Contributor

github-actions bot commented Oct 15, 2024

Logo
Checkmarx One – Scan Summary & Details66769dbd-9b6e-40d5-812e-2c7eb28b419f

No New Or Fixed Issues Found

cagonzalezcs
cagonzalezcs previously approved these changes Oct 15, 2024
Copy link
Contributor

@cagonzalezcs cagonzalezcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid from my side.

@jprusik jprusik added needs-qa Marks a PR as requiring QA approval and removed needs-qa Marks a PR as requiring QA approval labels Oct 15, 2024
@jprusik jprusik merged commit 6335dd6 into main Oct 21, 2024
27 of 29 checks passed
@jprusik jprusik deleted the pm-13687 branch October 21, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants