Pm 11525 estimated tax shown to customers potentially incorrect #11502
Conversation
| takeUntil(this.destroy$), | ||
| ) | ||
| .subscribe(); | ||
| this.taxFormGroup |
There was a problem hiding this comment.
Otherwise the sales tax may not calculate correctly for the United States. Some other countries also apply a sales tax unique per postal code such as Canary Islands, Ceuta in Spain.
| } | ||
| this.taxFormGroup.get("postalCode").updateValueAndValidity(); | ||
| }), | ||
| debounceTime(1000), |
There was a problem hiding this comment.
Delay calling out API if until no further input is received within 1 second.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11502 +/- ##
==========================================
- Coverage 33.17% 33.16% -0.01%
==========================================
Files 2779 2784 +5
Lines 86223 86234 +11
Branches 16420 16419 -1
==========================================
- Hits 28604 28602 -2
- Misses 55353 55364 +11
- Partials 2266 2268 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
No New Or Fixed Issues Found |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11525
📔 Objective
Calculate the sales tax using Stripe as our stored values are potentially incorrect.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes