[PM-13266] Import from LogMeOnce not working 2.0 #11452
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
bitwarden-bot
changed the title
djsmith85
reviewed
Oct 10, 2024
There was a problem hiding this comment.
@dlfi Thank you for your contribution.
The changes look pretty straightforward, but I was wondering, if you'd be up to adding some unit-tests to verify old and new behaviour.
Examples can be found under the libs/importer/spec-folder. There are a couple of csv-file-importers that have tests which you can use as guidance.
|
Thank you for approval for workflows @djsmith85 and I would be happy to do tests! Already thought about it. I will try as soon as possible. Should it be in this pull request or do I need to make a new issue for tests? |
|
@dlfi Tests should be added with this PR, then we can verify everything in one place before passing it on to QA. |
|
Hi @djsmith85 I just added the tests to PR. I hope I did it right, I was inspired by the tests you linked me to. Sorry it took so long. |
djsmith85
requested changes
Nov 5, 2024
Comment on lines
4
to
9
| import { data as logmeonceData2 } from "./test-data/logmeonce-csv/logmeonce.test.invalidRow.csv"; | ||
| import { data as logmeonceData6 } from "./test-data/logmeonce-csv/logmeonce.test.invalidUrl.csv"; | ||
| import { data as logmeonceData5 } from "./test-data/logmeonce-csv/logmeonce.test.missingName.csv"; | ||
| import { data as logmeonceData4 } from "./test-data/logmeonce-csv/logmeonce.test.mixedData.csv"; | ||
| import { data as logmeonceData3 } from "./test-data/logmeonce-csv/logmeonce.test.multipleEntries.csv"; | ||
| import { data as logmeonceData } from "./test-data/logmeonce-csv/logmeonce.test.validData.csv"; |
There was a problem hiding this comment.
Instead of re-naming the exports, could you please use meaningful names for the exported members within the testdata-files. You can then just import them here and won't need to rename.
Something like:
import { invalidRowData } from "./test-data/logmeonce-csv/logmeonce.test.invalidRow.csv";
import { missingNameData } from "./test-data/logmeonce-csv/logmeonce.test.missingName.csv";
There was a problem hiding this comment.
For sure! Thank you for the comment I just changed it.
djsmith85
previously approved these changes
Nov 5, 2024
djsmith85
approved these changes
Nov 5, 2024
|
New Issues
Fixed Issues
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11406
🎟️ Tracking
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes