[PM-16534] Rename CI workflows for Authenticator #333
Merged
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0dad6f2.
This reverts commit 49a2eab.
…roject"" This reverts commit 9bf6635.
Rename workflows by appending `_authenticator` to their names.
Renamed the following lanes in the Fastfile to be more specific to the Authenticator module: - `check` to `checkAuthenticator` - `setBuildVersionInfo` to `setAuthenticatorBuildVersionInfo` - `buildDebug` to `buildAuthenticatorDebug` - `buildRelease` to `buildAuthenticatorRelease` - `bundleRelease` to `bundleAuthenticatorRelease` - `distributeReleaseBundleToFirebase` to `distributeAuthenticatorReleaseBundleToFirebase` - `publishReleaseToGooglePlayStore` to `publishAuthenticatorReleaseToGooglePlayStore` Updated the GitHub workflows to use the new lane names. Removed unused `json_key_file` and `package_name` from Appfile. Added `json_key` parameter to `validate_play_store_json_key` lane in `build_authenticator.yml` workflow. Added `package_name` parameter to `publishAuthenticatorReleaseToGooglePlayStore` lane in `build_authenticator.yml` workflow.
Rename the output filenames of the Authenticator bundle and APK to `com.bitwarden.authenticator.aab` and `com.bitwarden.authenticator.apk` respectively. This improves the consistency of filenames across different build variants. Additionally, update `build.gradle.kts` to rename bundle and APK files to include the application ID in the file name, ensuring a unique file name for each build. This ensures consistent filenames regardless of build type or target.
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #333 +/- ##
=======================================
Coverage 44.67% 44.67%
=======================================
Files 119 119
Lines 5717 5717
Branches 684 684
=======================================
Hits 2554 2554
Misses 2981 2981
Partials 182 182 ☔ View full report in Codecov by Sentry. |
…on/update-fastfile # Conflicts: # .github/workflows/test_authenticator.yml # fastlane/Fastfile
…sistent-output-filenames
david-livefront
previously approved these changes
Feb 7, 2025
…pdate-fastfile # Conflicts: # .github/workflows/build.yml # fastlane/Fastfile
vvolkgang
dismissed
david-livefront’s stale review
The base branch was changed.
SaintPatrck
requested review from
brian-livefront and
phil-livefront
as code owners
…sistent-output-filenames
…sistent-output-filenames
vvolkgang
changed the base branch from
main
to
repo-migration/consistent-output-filenames
Base automatically changed from
repo-migration/consistent-output-filenames
to
main
February 12, 2025 22:31
vvolkgang
approved these changes
Feb 13, 2025
vvolkgang
changed the title
PeterDaveHello
added a commit
to PeterDaveHello/authenticator-android
that referenced
this pull request
Feb 24, 2025
PeterDaveHello
added a commit
to PeterDaveHello/authenticator-android
that referenced
this pull request
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
--
📔 Objective
Rename workflows by appending
_authenticatorto their names.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes