[BWA-86] Debug Menu #4 #276
Conversation
…rvice calls to unauthed bw apis
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
==========================================
+ Coverage 39.66% 41.28% +1.61%
==========================================
Files 112 118 +6
Lines 5503 5697 +194
Branches 646 679 +33
==========================================
+ Hits 2183 2352 +169
- Misses 3158 3163 +5
- Partials 162 182 +20 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
# Conflicts: # app/src/main/kotlin/com/bitwarden/authenticator/data/platform/manager/di/PlatformManagerModule.kt
andrebispo5
requested review from
brian-livefront,
ahaisting-livefront and
a team
as code owners
| } | ||
| } | ||
|
|
||
| private fun handleOpenDebugMenu() { | ||
| sendEvent(MainEvent.NavigateToDebugMenu) |
There was a problem hiding this comment.
Can we get a test for this event?
| /** | ||
| * Default implementation of the [DebugMenuRepository] | ||
| */ | ||
| class DebugMenuRepositoryImpl( |
There was a problem hiding this comment.
Can we get tests for this repo?
| @OptIn(ExperimentalMaterial3Api::class) | ||
| @Suppress("LongMethod") | ||
| @Composable | ||
| fun DebugMenuScreen( |
There was a problem hiding this comment.
Can we get tests for this screen?
| * ViewModel for the [DebugMenuScreen] | ||
| */ | ||
| @HiltViewModel | ||
| class DebugMenuViewModel @Inject constructor( |
There was a problem hiding this comment.
Can we get tests for this view model?
| */ | ||
| @Suppress("UNCHECKED_CAST") | ||
| @Composable | ||
| fun <T : Any> FlagKey<T>.ListItemContent( |
There was a problem hiding this comment.
Tests for DebugMenuScreen should give us coverage of this extension.
| /** | ||
| * Default implementation of the [DebugMenuLaunchManager] | ||
| */ | ||
| class DebugLaunchManagerImpl( |
There was a problem hiding this comment.
Missing tests DebugLaunchManagerImpl.
| setupDebugMenuDestination( | ||
| onNavigateBack = { | ||
| navController.popBackStack() | ||
| }, | ||
| ) |
There was a problem hiding this comment.
Can we cover these lines?
|
No New Or Fixed Issues Found |
|
Sorry @SaintPatrck for some reason I totally missed the test files in the main app, I blame the IDE 😆 |
andrebispo5
dismissed
SaintPatrck’s stale review
The base branch was changed.
# Conflicts: # app/src/main/kotlin/com/bitwarden/authenticator/data/platform/manager/di/PlatformManagerModule.kt
🎟️ Tracking
https://bitwarden.atlassian.net/browse/BWA-86
📔 Objective
Bring over the debug menu files from the main app and adjust the navigation flows.
📸 Screenshots
Screen.Recording.2024-11-06.at.12.28.16.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes