[BWA-86] Debug Menu #2 - config service #274
Merged
+804
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvice calls to unauthed bw apis
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
==========================================
+ Coverage 39.00% 39.28% +0.28%
==========================================
Files 108 111 +3
Lines 5448 5485 +37
Branches 633 638 +5
==========================================
+ Hits 2125 2155 +30
- Misses 3168 3173 +5
- Partials 155 157 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
andrebispo5
requested review from
brian-livefront,
ahaisting-livefront and
a team
as code owners
SaintPatrck
reviewed
Nov 11, 2024
| import com.bitwarden.authenticator.data.platform.datasource.network.api.ConfigApi | ||
| import com.bitwarden.authenticator.data.platform.datasource.network.model.ConfigResponseJson | ||
|
|
||
| class ConfigServiceImpl(private val configApi: ConfigApi) : ConfigService { |
There was a problem hiding this comment.
Public class needs kdoc.
|
No New Or Fixed Issues Found |
SaintPatrck
previously approved these changes
Nov 18, 2024
andrebispo5
dismissed
SaintPatrck’s stale review
The base branch was changed.
# Conflicts: # app/src/main/kotlin/com/bitwarden/authenticator/data/platform/datasource/network/di/PlatformNetworkModule.kt
SaintPatrck
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/BWA-86
📔 Objective
In order to have the debug menu we first need to bring over the layer to fetch server config that contain remote feature flags.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes