[BWA-86] Debug Menu #1 - network layer #272
Conversation
…rvice calls to unauthed bw apis
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
==========================================
+ Coverage 37.77% 39.00% +1.22%
==========================================
Files 99 108 +9
Lines 5294 5448 +154
Branches 606 633 +27
==========================================
+ Hits 2000 2125 +125
- Misses 3151 3168 +17
- Partials 143 155 +12 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
andrebispo5
requested review from
brian-livefront,
ahaisting-livefront and
a team
as code owners
| * Default [EnvironmentUrlDataJson] for the US region as written to disk by the legacy | ||
| * Xamarin app. | ||
| */ | ||
| val DEFAULT_LEGACY_US: EnvironmentUrlDataJson = EnvironmentUrlDataJson( |
There was a problem hiding this comment.
DEFAULT_LEGACY_US and DEFAULT_LEGACY_EU shouldn't be needed since we're not migrating legacy urls from anywhere.
There was a problem hiding this comment.
yap you are right
| * A [Call] for wrapping a network request into a [Result]. | ||
| */ | ||
| @Suppress("TooManyFunctions") | ||
| class ResultCall<T>( |
There was a problem hiding this comment.
Can we annotate with OmitFromCoverage? I don't see tests for this in the PM app either.
There was a problem hiding this comment.
ye for sure maybe we should do it the main app as well
|
No New Or Fixed Issues Found |
| /** | ||
| * An interceptor for "/identity" calls. | ||
| */ | ||
| val identityInterceptor: BaseUrlInterceptor = BaseUrlInterceptor() | ||
|
|
||
| /** | ||
| * An interceptor for "/events" calls. | ||
| */ | ||
| val eventsInterceptor: BaseUrlInterceptor = BaseUrlInterceptor() |
There was a problem hiding this comment.
⛏️ These will not be used since we're only communicating with the config endpoint.
There was a problem hiding this comment.
Ye I'll remove them doesn't make sense for them to be here at this point
🎟️ Tracking
https://bitwarden.atlassian.net/browse/BWA-86
📔 Objective
In order to have the debug menu we first need to bring over the network layer from the main app to be able to fetch server config that contain remote feature flags.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes