Skip to content

PM-33112: Avoid double announcement of BitwardenSwitch content description#6611

Merged
david-livefront merged 1 commit intomainfrom
PM-33112-switch-content-description
Mar 4, 2026
Merged

PM-33112: Avoid double announcement of BitwardenSwitch content description#6611
david-livefront merged 1 commit intomainfrom
PM-33112-switch-content-description

Conversation

@david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Mar 3, 2026

🎟️ Tracking

PM-33112

📔 Objective

This PR removes a double announcement of BitwardenSwitch labels. The top-level contentDescription will now use either the supplied contentDescription or the label as a fallback, the label text will no longer be announced separately.

@david-livefront david-livefront added the t:bug Change Type - Bug label Mar 3, 2026
@github-actions github-actions bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context and removed t:bug Change Type - Bug labels Mar 3, 2026
@david-livefront david-livefront marked this pull request as ready for review March 3, 2026 23:13
@david-livefront david-livefront requested a review from a team as a code owner March 3, 2026 23:13
@david-livefront david-livefront added the t:bug Change Type - Bug label Mar 3, 2026
@david-livefront david-livefront changed the title PM-33112: Avoid double announcement of BitwardnSwitch content description PM-33112: Avoid double announcement of BitwardenSwitch content description Mar 3, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

Logo
Checkmarx One – Scan Summary & Detailsc64916cd-e07d-4b53-a33a-80202832bff0

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.46%. Comparing base (cf1455a) to head (148bdfc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6611      +/-   ##
==========================================
+ Coverage   85.75%   86.46%   +0.70%     
==========================================
  Files         932      788     -144     
  Lines       59667    56969    -2698     
  Branches     8361     8301      -60     
==========================================
- Hits        51170    49258    -1912     
+ Misses       5589     4829     -760     
+ Partials     2908     2882      -26     
Flag Coverage Δ
app-data 17.49% <ø> (-0.23%) ⬇️
app-ui-auth-tools 20.89% <ø> (-0.33%) ⬇️
app-ui-platform 15.08% <ø> (-0.60%) ⬇️
app-ui-vault 25.80% <ø> (-0.67%) ⬇️
authenticator 6.70% <ø> (ø)
lib-core-network-bridge 4.31% <ø> (+0.19%) ⬆️
lib-data-ui 0.93% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-livefront david-livefront added this pull request to the merge queue Mar 4, 2026
Merged via the queue into main with commit 9f274bb Mar 4, 2026
29 of 30 checks passed
@david-livefront david-livefront deleted the PM-33112-switch-content-description branch March 4, 2026 00:59
@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:bug Change Type - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants