[PM-27834] Use Authenticator Bridge as a project reference

[vvolkgang]

🎟️ Tracking

PM-27834

📔 Objective

Use Authenticator Bridge as a project reference instead of the compiled binary.

📸 Screenshots

• First item added to PM through BWA
• Second item from a cipher in PM

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – ddea9659-b79b-439a-9fca-9a9f4f07f743

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.90%. Comparing base (4b7fcdb) to head (afa24de).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5793   +/-   ##
=======================================
  Coverage   84.90%   84.90%           
=======================================
  Files         724      724           
  Lines       52780    52780           
  Branches     7672     7672           
=======================================
  Hits        44811    44811           
  Misses       5277     5277           
  Partials     2692     2692           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[claude]

Claude finished @vvolkgang's task —— View job

---

PR Review Complete ✅

Todo List

• Gather context and examine PR changes
• Review build.gradle.kts modifications
• Verify AAR deletion and project reference approach
• Provide detailed review feedback

---

Summary

This PR successfully replaces the precompiled Authenticator Bridge AAR library (v1.0.1) with a project reference in both the :app and :authenticator modules. The change is straightforward and improves the development workflow by enabling direct source code access and debugging.

Changes Review

Modified Files:

• app/build.gradle.kts:223 - Changed from files("libs/authenticatorbridge-1.0.1-release.aar") to project(":authenticatorbridge")
• authenticator/build.gradle.kts:179 - Changed from files("libs/authenticatorbridge-1.0.1-release.aar") to project(":authenticatorbridge")
• Deleted both AAR files from app/libs/ and authenticator/libs/

Assessment

✅ Strengths:

• Clean, minimal change with clear intent
• Properly removes obsolete AAR files (addresses @david-livefront's review comment)
• :authenticatorbridge module is correctly configured in settings.gradle.kts:54
• Module follows proper Android library structure with appropriate dependencies
• All CI checks passed (Lint, Tests, Checkmarx security scan)
• Coverage maintained at 84.90% (per Codecov)
• Follows established pattern - other modules already use project references (:core, :data, :network, :ui)

📝 Observations:

• The :authenticatorbridge module exists as an Android library module with version 1.0.1
• Module has proper ProGuard configuration and consumer rules
• Uses AIDL for inter-process communication (appropriate for the bridge architecture)
• Dependencies are appropriately scoped (only includes :annotation, :core, and essential AndroidX libraries)

Architecture Compliance

This change aligns with the project's modular architecture as documented in the codebase:

• Maintains proper module boundaries
• Follows the established pattern for internal module dependencies
• Enables better build cache utilization and incremental compilation
• Improves developer experience with direct source access

Recommendation

Approve ✅ - This is a solid refactoring that improves the development workflow without introducing any risks. The change is well-tested through CI, and the approach is consistent with how other internal modules are consumed in the project.