-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-8217] Add local feature flag to ignore environment validation #4516
[PM-8217] Add local feature flag to ignore environment validation #4516
Conversation
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/2024.12-rc13 #4516 +/- ##
=====================================================
Coverage 88.87% 88.87%
=====================================================
Files 460 460
Lines 39899 39903 +4
Branches 5685 5688 +3
=====================================================
+ Hits 35461 35465 +4
- Misses 2456 2457 +1
+ Partials 1982 1981 -1 ☔ View full report in Codecov by Sentry. |
} returns true | ||
every { | ||
featureFlagManager.getFeatureFlag(FlagKey.NewDeviceTemporaryDismiss) | ||
} returns true | ||
policyManager.getActivePolicies(type = PolicyTypeJson.REQUIRE_SSO) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8217
📔 Objective
In order for QA to fully test the new device two factor notice feature, we need to bypass the requirement of only showing the notice to Bitwarden Cloud environments.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes