Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-8217] Add local feature flag to ignore environment validation #4516

Merged

Conversation

andrebispo5
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-8217

📔 Objective

In order for QA to fully test the new device two factor notice feature, we need to bypass the requirement of only showing the notice to Bitwarden Cloud environments.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Logo
Checkmarx One – Scan Summary & Details5098ca13-d276-47fb-87f3-16cc9363bf35

No New Or Fixed Issues Found

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.87%. Comparing base (a35ec8c) to head (d8c8e33).
Report is 1 commits behind head on release/2024.12-rc13.

Files with missing lines Patch % Lines
...ature/debugmenu/components/FeatureFlagListItems.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/2024.12-rc13    #4516   +/-   ##
=====================================================
  Coverage                 88.87%   88.87%           
=====================================================
  Files                       460      460           
  Lines                     39899    39903    +4     
  Branches                   5685     5688    +3     
=====================================================
+ Hits                      35461    35465    +4     
- Misses                     2456     2457    +1     
+ Partials                   1982     1981    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

} returns true
every {
featureFlagManager.getFeatureFlag(FlagKey.NewDeviceTemporaryDismiss)
} returns true
policyManager.getActivePolicies(type = PolicyTypeJson.REQUIRE_SSO)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrebispo5 andrebispo5 changed the base branch from main to release/2024.12-rc13 January 6, 2025 12:55
@andrebispo5 andrebispo5 merged commit 02d3c19 into release/2024.12-rc13 Jan 6, 2025
8 checks passed
@andrebispo5 andrebispo5 deleted the pm-8217/local-flag-ignore-env-validation branch January 6, 2025 12:55
@andrebispo5 andrebispo5 restored the pm-8217/local-flag-ignore-env-validation branch January 6, 2025 13:01
@andrebispo5 andrebispo5 deleted the pm-8217/local-flag-ignore-env-validation branch January 6, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants