-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-14240] Add Quetta Browser to Privileged Apps #4189
Open
SymphonicDeviation
wants to merge
23
commits into
bitwarden:main
Choose a base branch
from
SymphonicDeviation:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+12
โ0
Open
Changes from 16 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
043c8f4
privilegedApps
SymphonicDeviation 4b0dec2
privilegedApps
SymphonicDeviation 0390722
Merge branch 'main' into main
SymphonicDeviation 52396e9
Merge branch 'main' into main
SymphonicDeviation 2a31fb5
Merge branch 'main' into main
SymphonicDeviation be5c301
Merge branch 'main' into main
SymphonicDeviation f9baea1
Merge branch 'main' into main
SymphonicDeviation e4fa16a
Merge branch 'bitwarden:main' into main
SymphonicDeviation bc15df9
Merge branch 'bitwarden:main' into main
SymphonicDeviation 6d06fd3
Merge branch 'main' into main
SymphonicDeviation 493560c
Merge branch 'main' into main
SymphonicDeviation 0772b74
Merge branch 'bitwarden:main' into main
SymphonicDeviation 023b3a2
Merge branch 'main' into main
SymphonicDeviation d5fcb00
Merge branch 'main' into main
SymphonicDeviation 62e744d
Merge branch 'main' into main
SymphonicDeviation 0e1ee1b
Merge branch 'main' into main
SymphonicDeviation 920855e
Merge branch 'main' into main
SymphonicDeviation aeeeaa8
Merge branch 'main' into main
SymphonicDeviation f6139cf
Merge branch 'main' into main
SymphonicDeviation 9293254
Merge branch 'main' into main
SymphonicDeviation 56c93ec
Merge branch 'bitwarden:main' into main
SymphonicDeviation 6867fc7
Removed Unknown SHA256 Fingerprint for Quetta Browser
SymphonicDeviation fe8c08c
Merge branch 'main' into main
SymphonicDeviation File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are there two fingerprints here? I suppose one is from Google Play but what would be the other one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, it has been a few weeks since I've made this commit. I used "App Manager" to get the sha256 values. I tested it again without that other fingerprint and it seems to be working fine. It must have been removed since I do not see that sha256 fingerprint in "App Manager".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case this would be a security concern, I'd take it off;
BE:FE:E7:31:12:6A:A5:6E:7E:FD:AE:AF:5E:F3:FA:EA:44:1C:19:CC:E0:CA:EC:42:6B:65:BB:F8:2C:59:46:80 I can confirm is from the Play Store, but the other one I cannot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I did take it off and removed it on my end. I'll be pushing the commit with the removal to my version/repo once I am home tonight. And if you're not aware, Quetta also updated the browser to support autofill, I tested the browser with the latest commits in the custom built apk. I can confirm that the autofill works with bitwarden now.