Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix locked accounts #1728

Open
wants to merge 14 commits into
base: hardfork
Choose a base branch
from
Open

Fix locked accounts #1728

wants to merge 14 commits into from

Conversation

OpenLedgerApp
Copy link
Contributor

@OpenLedgerApp OpenLedgerApp commented Apr 22, 2019 •
edited by abitmore
Loading

@sschiessl-bcp
Copy link

Can you please point me to the issue # behind this PR?

@abitmore
Copy link
Member

abitmore commented Jul 2, 2019

@sschiessl-bcp
Copy link

sschiessl-bcp commented Jul 2, 2019 •
edited
Loading

From reading the BSIPs and issues I am confused what is done and still needs doing. A massive amount of hours is invested here.

Is there a roadmap or something similar for this task?

@OpenLedgerApp
Copy link
Contributor Author

OpenLedgerApp commented Jul 4, 2019 •
edited
Loading

From reading the BSIPs and issues I am confused what is done and still needs doing. A massive amount of hours is invested here.

Is there a roadmap or something similar for this task?

@sschiessl-bcp, we had tasks list for this BSIP.

At the first step, we have made research to identify locked accounts.
Then we have summarised the most liquid currencies of locked accounts.
At the second step, we have implemented "Prevent to create cycled authorities".
At the third step, we offered two ways how to fix locked accounts:

  1. Automatic (unconditional)
  • Detect all locked accounts in first maintenance after hardfork.
  • Find latest operation ("lock"-operation) among operations of cycled accounts. Do it for each cycle.
  • Undo all "lock"-operations. Find previous account update/create an operation that changes authorities and redo it.
  1. Manual (on-demand)
  • Check if an account is locked.
  • Find latest operation ("lock"-operation) in cycle.
  • Undo "lock"-operation.

We have implemented to unlock accounts manually. It's a better idea because we don't know exactly if locking of accounts was by mistake or not.

In conclusion, all Pull Request with the smoke and unit tests we published on GitHub. We have finished all task for this BSIP according to our specification.

However, we have only one open question "how to take 10% from each account as payment for the implementation".

@sschiessl-bcp
Copy link

Can you comment how exactly the manual way should work?

@OpenLedgerApp
Copy link
Contributor Author

@sschiessl-bcp, we see the following use case for "manual fix of locked accounts":

Preconditions:
A User should have a valid authority which preceded account lock state.

Steps:

  1. User creates unlock_account_operation with account_to_unlock as parameter
  2. User signs the operation with his previous authority

Expected Results:
Account authority is returned to its previous state

@dayman32
Copy link

Can I unlock it manually now? or Do you still need hardfork?

@sschiessl-bcp
Copy link

Can I unlock it manually now? or Do you still need hardfork?

This is ongoing development and a core change, don't expect anything before autumn.

Alexey Frolov and others added 14 commits July 31, 2019 11:32
Prevent to create cycled accounts + unit tests
d892bac
Add unit tests: verify_cycled_authority
0896224
Add verify_cycled_authority
e93b203 
Find locked accounts.
Prevent update + create locked account. UT.
Add unit tests: max auth depth limit
Fix unit tests after merge
d5fdd5a 
Remove unnecessary code
@dyakovitsky
CORE-978 BSIP-Fix-locked: fix unit tests cli_test
3c6048b
save restore point of account authority
f7ee13f 
unit test: get restore point
Modify unit tests
17488ed 
 - add restore point test
 - fix authority depth limit test
Add account_unlock_operation
bdaa7ac
Authorize unlock_account_operation
9ab5e25
add unlock account unit tests (chain)
4bbf0dc
conflict resolving result
2e2ad28
.fix-locked_accounts main logic impl
e392b20
unit tests
3095f2a
utests adjustment and hforck time fix
3256407
@dayman32
Copy link

dayman32 commented Nov 9, 2019 •
edited
Loading

Has anything changed? Can I somehow withdraw funds from blocked accounts?

When is Hardfork?

@pmconrad
Copy link
Contributor

Has anything changed? Can I somehow withdraw funds from blocked accounts?

No.

When is Hardfork?

The next planned hardfork will not include a fix for this. The relevant BSIP is still being written. Even the BSIPs that were completed in the past month have not been voted in, so don't hold your breath.

@dayman32
Copy link

Another 1 year has passed. Anyone looking for a solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hardfork
Projects
None yet
Milestone
Future Protocol Upgrade Release
Development

Successfully merging this pull request may close these issues.
7 participants
@OpenLedgerApp @sschiessl-bcp @abitmore @dayman32 @pmconrad @ryanRfox @dyakovitsky