Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optimizer support for Python <= 3.9 #1379

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

matthewdouglas
Copy link
Member

@matthewdouglas matthewdouglas commented Sep 30, 2024

Fixes #1376

We don't support macOS yet, but the issue for Python <= 3.9 would still exist on other platforms.

@SunMarc

@matthewdouglas matthewdouglas added the bug Something isn't working label Sep 30, 2024
@matthewdouglas matthewdouglas self-assigned this Sep 30, 2024
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense, thanks for fixing !

@matthewdouglas matthewdouglas merged commit 51294d9 into main Sep 30, 2024
56 checks passed
@akx
Copy link
Contributor

akx commented Oct 10, 2024

Python 3.8 is EOL as of 3 days ago though 😄

https://endoflife.date/python

EDIT: Oh, right, strict=True was added in 3.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.9 support broken in 0.44.0
3 participants