Skip to content

windows platform build #5579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
matiu merged 5 commits into from
Mar 10, 2017
Merged

windows platform build #5579

matiu merged 5 commits into from
Mar 10, 2017

Conversation

@gabrielbazan7
Copy link
Collaborator

@gabrielbazan7 gabrielbazan7 commented Feb 7, 2017 •
edited
Loading

  • Steps to make the scanner works:
    npm run apply:bitpay && npm run start:windows
    cd plugins/cordova-plugin-qrscanner
    npm i
    npm run build
    Go to root
    rm -rf platforms/windows
    cordova platform add windows
    add to cordova project index.html file and to add manifest file:
<script type="text/javascript" src="plugins/cordova-plugin-qrscanner/www/www.min.js"></script>

<DeviceCapability Name="webcam" />

@gabrielbazan7 gabrielbazan7 mentioned this pull request Feb 7, 2017
Closed
@gabrielbazan7 gabrielbazan7 force-pushed the windows-platform branch 2 times, most recently from 09c399b to ac4f42c Compare February 16, 2017 22:23
@gabrielbazan7 gabrielbazan7 changed the title windows platform build WIP: windows platform build Feb 20, 2017
@JDonadio
Copy link
Contributor

JDonadio commented Feb 21, 2017 •
edited
Loading

Related https://github.com/bitpay/copay/issues/5306

@gabrielbazan7 gabrielbazan7 changed the title WIP: windows platform build windows platform build Mar 10, 2017
matiu
matiu approved these changes Mar 10, 2017
View reviewed changes
app-template/package-template.json
"bezier-easing": "^2.0.3",
"bhttp": "^1.2.1",
"bitauth": "^0.3.2",
"bitauth": "[email protected]:gabrielbazan7/bitauth.git#copay",
Copy link
Contributor

@matiu matiu Mar 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, this is temporary until: bitpay/bitauth#63 is merged.

@matiu matiu merged commit 85215cb into bitpay:master Mar 10, 2017
@matiu matiu removed the In Progress label Mar 10, 2017
@matiu
Copy link
Contributor

matiu commented Mar 10, 2017

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@matiu matiu matiu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gabrielbazan7 @JDonadio @matiu