update deprecated keycloak admin deprecated env variables: https://ww…

[singatias]

Description of the change

Minor changes to change KEYCLOAK_ADMIN and KEYCLOAK_ADMIN_PASSWORD environment and secret variables to update to the new values KC_BOOTSTRAP_ADMIN_USERNAME, KC_BOOTSTRAP_ADMIN_PASSWORD

Benefits

remove the deprecation message and reduce the upcoming maintenance when the env variables are removed

Possible drawbacks

could be confusing for people who update the container and don't pay attention to the env variable changes

Applicable issues

none

Additional information

I noticed the deprecation messages on my new instance of Keycloak and decided to make the changes since they were minor

Related chart PR: bitnami/charts#30636

[migruiz4]

Hi @singatias, thank you for your contribution!

The changes looks good to me with some suggestions, but we need to wait until Keycloak 25.x is removed from our catalog order in order to merge these changes.

That is the reason why our CI pipeline fails, since those new variables are only supported on Keycloak 26.x.

My request for this code review:

• Please remove your changes from the keycloak/25 folder to avoid future conflicts when it is removed soon.
• Please add a note under the Notable Changes section in the README
• Additionally, add a warning under the keycloak_validate section to warn users that still use the deprecated env variables.

keycloak_validate() {
    ...
    [[ -n "${KEYCLOAK_ADMIN:-}" || -n "${KEYCLOAK_ADMIN_USER:-}" ]] && warn "The KEYCLOAK_ADMIN environment variable has been removed, please use KC_BOOTSTRAP_ADMIN_USERNAME instead."
    [[ -n "${KEYCLOAK_ADMIN_PASSWORD:-}" ]] && warn "The KEYCLOAK_ADMIN environment variable has been removed, please use KC_BOOTSTRAP_ADMIN_PASSWORD instead."

[singatias]

Hi @singatias, thank you for your contribution!

The changes looks good to me with some suggestions, but we need to wait until Keycloak 25.x is removed from our catalog order in order to merge these changes.

That is the reason why our CI pipeline fails, since those new variables are only supported on Keycloak 26.x.

My request for this code review:

• Please remove your changes from the keycloak/25 folder to avoid future conflicts when it is removed soon.
• Please add a note under the Notable Changes section in the README
• Additionally, add a warning under the keycloak_validate section to warn users that still use the deprecated env variables.

keycloak_validate() {
    ...
    [[ -n "${KEYCLOAK_ADMIN:-}" || -n "${KEYCLOAK_ADMIN_USER:-}" ]] && warn "The KEYCLOAK_ADMIN environment variable has been removed, please use KC_BOOTSTRAP_ADMIN_USERNAME instead."
    [[ -n "${KEYCLOAK_ADMIN_PASSWORD:-}" ]] && warn "The KEYCLOAK_ADMIN environment variable has been removed, please use KC_BOOTSTRAP_ADMIN_PASSWORD instead."

Thank you for guiding me. Let me know if there is anything else :)