Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/harbor] made generating existing/default secret secrets an option #31079

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cthtrifork
Copy link

@cthtrifork cthtrifork commented Dec 17, 2024

Description of the change

This adds an option to disable generation of templated secrets. Default is set to true to keep current behaviour intact.

Benefits

We have several scanners, such as polaris which is picking up that secrets are created by the chart. We are using external-secrets and want to create all secrets out of band.

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added harbor triage Triage is needed labels Dec 17, 2024
@github-actions github-actions bot requested a review from javsalgar December 17, 2024 21:14
@cthtrifork cthtrifork changed the title bitnami/harbor made generating existing/default secret secrets an option [bitnami/harbor] made generating existing/default secret secrets an option Dec 17, 2024
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Dec 18, 2024
@github-actions github-actions bot removed the triage Triage is needed label Dec 18, 2024
@github-actions github-actions bot removed the request for review from javsalgar December 18, 2024 09:11
@github-actions github-actions bot requested a review from migruiz4 December 18, 2024 09:12
Signed-off-by: Bitnami Containers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
harbor in-progress verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[harbor] Allow providing all secrets out-of-band
5 participants