Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/keycloak] improve keycloak value file comments on extraEnvVars property #31054

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alshf89
Copy link

@alshf89 alshf89 commented Dec 16, 2024

Description of the change
This pull request fixes a typo in the comments of the values.yaml file in the chart. The change only updates the comments and does not affect any functionality or behavior of the chart.

Benefits
Improves the readability and clarity of the comments in the values.yaml file.
Aligns the file with the intended documentation standards.

Possible drawbacks
None. This change is limited to a typo correction in the comments.

Applicable issues
None.

Additional information
This is a minor documentation update and does not require version bumping in Chart.yaml.

Checklist

@alshf89
Copy link
Author

alshf89 commented Dec 16, 2024

I'm not sure If I need to bump the chart version for it or not

@carrodher
Copy link
Member

Thanks for your contribution! Yes, please, could you bump the chart version in the Chart.yaml? This is necessary to test the changes and cut a new release.

In the same way, this is just a friendly reminder that signing your commits is important. Your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

@alshf89 alshf89 force-pushed the chore/improve-keycloak-value-file-comments branch from 467123a to 96b1ec8 Compare December 16, 2024 21:45
Signed-off-by: Bitnami Containers <[email protected]>
@alshf89
Copy link
Author

alshf89 commented Dec 16, 2024

@carrodher Thanks for the reminder, I've just bumped the chart version in Chart.yaml and signed the commit. Let me know if there's anything else needed.

@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Dec 16, 2024
@github-actions github-actions bot removed the triage Triage is needed label Dec 16, 2024
@github-actions github-actions bot removed the request for review from javsalgar December 16, 2024 22:05
@github-actions github-actions bot requested a review from gongomgra December 16, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress keycloak verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants