Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/harbor] Fix REGISTRY_HTTP_SECRET creation when not using an existing secret #31013

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

uivraeus
Copy link

Description of the change

Ensure that REGISTRY_HTTP_SECRET can be assigned when there is no existing Secret with a value for it.

The fix is to let the temporary variable used for a potentially existing secret value default to an empty string. This follows the implementation strategy applied in "core-secret-envvars.yaml"

Benefits

Possible to control the value of REGISTRY_HTTP_SECRET

Possible drawbacks

None

Applicable issues

Additional information

None

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Ensure that temporary variable defaults to empty string if there is not existing value for the secret key. This follows the implementation strategy applied in "core-secret-envvars.yaml"

Signed-off-by: Ulf Ivraeus <[email protected]>
@github-actions github-actions bot added harbor triage Triage is needed labels Dec 12, 2024
@github-actions github-actions bot requested a review from javsalgar December 12, 2024 12:31
Signed-off-by: Bitnami Containers <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Dec 12, 2024
@github-actions github-actions bot removed the triage Triage is needed label Dec 12, 2024
@github-actions github-actions bot removed the request for review from javsalgar December 12, 2024 14:37
@github-actions github-actions bot requested a review from gongomgra December 12, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
harbor in-progress verify Execute verification workflow for these changes
Projects
None yet
5 participants