[bitnami/kibana] template server.publicBaseUrl in all variants #30807
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if .Values.extraConfiguration."server.publicBaseUrl" was specified (with a dot in the key), that key was inserted into the configmap twice, causing Kibana to error out. Furthermore, since the introduction of the fallback to the ingress hostname, this setting couldn't be templated anymore (which was possible before). This commit allows the templating as well as specifying it with the dot notation. Signed-off-by: Jan-Philipp Litza <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
carrodher
added
verify
Signed-off-by: Bitnami Containers <[email protected]>
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Previously, if
.Values.extraConfiguration."server.publicBaseUrl"was specified (with a dot in the key), that key was inserted into the configmap twice, causing Kibana to error out.Furthermore, since the introduction of the fallback to the ingress hostname, this setting couldn't be templated anymore (which was possible before).
This commit allows the templating as well as specifying it with the dot notation.
Benefits
Upgrades from old chart versions that specified the dotted extraConfiguration won't break the deployment.
Also, templating the publicBaseUrl is possible again.
Possible drawbacks
None.
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm