Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/harbor] Invalid logic prevents assignment or auto-generation of REGISTRY_HTTP_SECRET in harbor-registry secret #31008

Open
uivraeus opened this issue Dec 12, 2024 · 1 comment · May be fixed by #31013
Assignees
Labels
harbor tech-issues The user has a technical issue about an application triage Triage is needed

Comments

@uivraeus
Copy link

Name and Version

bitnami/harbor 24.0.2

What architecture are you using?

amd64

What steps will reproduce the bug?

  1. Run helm template --set registry.secret=0123456789abcdef harbor-24.0.2.tgz | grep REGISTRY_HTTP_SECRET
  2. The result is PG5pbD4=, when decoded equals <nil>

Are you using any custom parameters or values?

Yes, I'm overriding the registry.secret value (but I'm not assigning the registry.existingSecret value)

See "steps to reproduce" above.

What is the expected behavior?

The Secret created should include a key REGISTRY_HTTP_SECRET with the value provided in the override

What do you see instead?

PG5pbD4=, when decoded equals <nil>

Additional information

It looks like this bug was introduced by the fix for #29372, where the following lines cause the current problem:

{{- $registryHttpSecret := $existingEnvVarsSecretRegistry.REGISTRY_HTTP_SECRET }}
{{- if eq $registryHttpSecret "" }}

If there is no existing secret, then $registryHttpSecret will be null, but the if statement checks for the empty string, which is not the same thing.

@uivraeus uivraeus added the tech-issues The user has a technical issue about an application label Dec 12, 2024
@github-actions github-actions bot added the triage Triage is needed label Dec 12, 2024
@carrodher
Copy link
Member

Thank you for bringing this issue to our attention. We appreciate your involvement! If you're interested in contributing a solution, we welcome you to create a pull request. The Bitnami team is excited to review your submission and offer feedback. You can find the contributing guidelines here.

Your contribution will greatly benefit the community. Feel free to reach out if you have any questions or need assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
harbor tech-issues The user has a technical issue about an application triage Triage is needed
Projects
None yet
3 participants