Rename "processor" to "handler" #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… term that indicates handling local database rows in provider source code)
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR performs a systematic refactoring to rename classes from *Processor to *Handler across the calendar mapping layer, along with updating the package name from processor to handler. This improves naming consistency and clarity throughout the codebase.
Key changes:
- Renamed interface
AndroidEventFieldProcessortoAndroidEventFieldHandler - Renamed all implementing classes (e.g.,
UrlProcessor→UrlHandler,UidProcessor→UidHandler) - Updated package names from
at.bitfire.synctools.mapping.calendar.processortoat.bitfire.synctools.mapping.calendar.handler - Updated all test classes and variable names to match the new naming convention
Reviewed Changes
Copilot reviewed 47 out of 47 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| AndroidEventHandler.kt | Updated imports and renamed main class from AndroidEventProcessor to AndroidEventHandler; renamed field fieldProcessors to fieldHandlers |
| AndroidEventFieldHandler.kt | Renamed interface from AndroidEventFieldProcessor to AndroidEventFieldHandler |
| *Handler.kt (main files) | Renamed all handler classes and updated package declarations |
| *HandlerTest.kt (test files) | Renamed all test classes, updated package declarations, and renamed test variables from processor to handler |
| EndTimeBuilder.kt | Updated KDoc reference to use new class name |
Comments suppressed due to low confidence (2)
lib/src/main/kotlin/at/bitfire/synctools/mapping/calendar/handler/UidHandler.kt:17
- The comment still references
AndroidEventProcessorwhich has been renamed toAndroidEventHandler. Update the comment to reflect the new class name.
lib/src/main/kotlin/at/bitfire/synctools/mapping/calendar/AndroidEventHandler.kt:223 - The comment still references
UidProcessorwhich has been renamed toUidHandler. Update the comment to reflect the new class name.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sunkup
requested changes
Nov 10, 2025
Member
sunkup
left a comment
sunkup
left a comment
There was a problem hiding this comment.
There are a few comments which are missing. The ones I found are:
UidHandlerstill referencesAndroidEventProcessorin a comment.- kdoc of
UnknownPropertiesHandler.EXCLUDEDtalks about "processors" twice AndroidEventHandlermentionsUidProcessorinstead ofUidHandlerin a comment
sunkup
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because "row handler" is an existing term that indicates handling local database rows in provider source code and it's also shorter.
Also we already use the terms builder / handler for contacts (in the vcard4android legacy package).