Add support for ZonedDateTime in EventHandler
#136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
rfc2822
reviewed
Nov 10, 2025
Member
rfc2822
left a comment
rfc2822
left a comment
There was a problem hiding this comment.
See #135 (comment)
The "parse and catch exception" approach doesn't seem to be a proper solution, at least not in the handle().
I think we should define a separate parseStartDate() method that
- has well-defined inputs and outputs,
- supports the required input formats,
- is tested separately.
Within that method, we should use other methods to determine the input format. If that's really not possible, we can still use the exception method.
Comment on lines
38
to
40
| // Some server providers (e.g. t-mobile) include time information | ||
| // This is allowed by RFC2426: https://www.rfc-editor.org/rfc/rfc2426#section-3.1.5 | ||
| // And RFC6350: https://www.rfc-editor.org/rfc/rfc6350#section-6.2.5 |
Member
There was a problem hiding this comment.
This code is not related to vCard, as it only handles the field of the local contacts provider. So RFCs about vCard don't apply.
Member
There was a problem hiding this comment.
Besides from empty, I think we should test at least
- the four formats of the AOSP Contacts app (see issue),
- possibly additional common date / date-time formats that we want to support.
Signed-off-by: Arnau Mora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #135 and bitfireAT/davx5-ose#1797.