Use TH quotes more to eliminate some CPP #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeofilC
force-pushed
the
wip/teo/less-cpp
branch
from
f9bd127 to
21a1a1a
Compare
|
What do you think about this @parsonsmatt ? If you are a fan of this direction, I can try to also get rid of the CPP caused by |
|
I'll investigate these failures soon |
parsonsmatt
reviewed
Oct 30, 2024
src/Database/Esqueleto/Record.hs
Outdated
| -- `where` clause. | ||
| [] | ||
| ] | ||
| [d| sqlSelectColCount _ = sqlSelectColCount (Proxy @($(pure joinedTypes))) |] |
There was a problem hiding this comment.
Huh - there are two mentions of sqlSelectColCount. This is one. Is it posible that the [d| ... |] here is doing newName instead of using the name in scope?
There was a problem hiding this comment.
I think you are right. This is quite odd behaviour (but also the type of issues I was hoping to find with this PR). I'll make a GHC ticket.
Strangely as welll
[d| $(varP 'foo) = ...|] is fine but as soon as I try to add arguments, it fails to parse, so I moved those into a lambda
There was a problem hiding this comment.
parsonsmatt
approved these changes
Dec 26, 2024
|
Cheers! Happy holidays |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates some CPP by switching to using TH quotes.
Before submitting your PR, check that you've:
stylish-haskelland otherwise adhered to the style guide.After submitting your PR: