Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newsletter 257 translate in french #1182

Merged
merged 17 commits into from
Aug 7, 2023
Merged

Newsletter 257 translate in french #1182

merged 17 commits into from
Aug 7, 2023

Conversation

Copinmalin
Copy link
Contributor

No description provided.

murchandamus
murchandamus reviewed Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@murchandamus murchandamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed a couple small things

_posts/fr/newsletters/2023-06-28-newsletter.md Outdated

{% include references.md %}
{% include linkers/issues.md v=2 issues="6303,2701,2696,7710,2368,2367,2319,2120,2089,2077,1129" %}
[policy series]: /en/blog/waiting-for-confirmation/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link should probably be to the French page of the series?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I think @Copinmalin is still working on translating the policy series for this newsletter (its still in en)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started out hoping that others would be able to add to it, but I think I'm alone...

I'm now back from holiday and I'm going to try to make up for lost time

_posts/fr/newsletters/2023-06-28-newsletter.md Outdated
@@ -0,0 +1,226 @@
---
title: 'Bulletin hebdomadaire Bitcoin Optech #257'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scrolling over the french newsletters page, I’ve noticed that the titles are a mix of “Bulletin hebdomadaire”, and “Bulletin Hebdomadaire”, with older issues also using other titles. Should we perhaps align them all on a single title scheme? Which do you think would be the best?

2020-12-23-newsletter.md:title: 'Bulletin Bitcoin Optech #129: Revue spéciale Année 2020'
2021-12-22-newsletter.md:title: 'Bulletin Bitcoin Optech #180: Spécial Bilan 2021'
2022-09-07-newsletter.md:title: 'Bitcoin Optech Newsletter #216'
2022-09-14-newsletter.md:title: 'Bitcoin Optech Newsletter #217'
2022-09-21-newsletter.md:title: 'Bitcoin Optech Newsletter #218'
2022-09-28-newsletter.md:title: 'Bitcoin Optech Newsletter #219'
2022-10-05-newsletter.md:title: 'Bitcoin Optech Newsletter #220'
2022-10-12-newsletter.md:title: 'Bitcoin Optech Newsletter #221'
2022-10-19-newsletter.md:title: 'Bitcoin Optech Newsletter #222'
2022-10-26-newsletter.md:title: 'Bitcoin Optech Newsletter #223'
2022-11-02-newsletter.md:title: 'Bitcoin Optech Newsletter #224'
2022-11-09-newsletter.md:title: 'Bitcoin Optech Newsletter #225'
2022-11-16-newsletter.md:title: 'Bitcoin Optech Newsletter #226'
2022-11-23-newsletter.md:title: 'Bitcoin Optech Newsletter #227'
2022-11-30-newsletter.md:title: 'Bitcoin Optech Newsletter #228'
2022-12-07-newsletter.md:title: 'Bitcoin Optech Newsletter #229'
2022-12-14-newsletter.md:title: 'Bitcoin Optech Newsletter #230'
2022-12-21-newsletter.md:title: 'Lettre informative Bitcoin Optech #231: Spéciale Revue annuelle 2022'
2023-01-04-newsletter.md:title: 'Bitcoin Optech Newsletter #232'
2023-01-11-newsletter.md:title: 'Bulletin hebdomadaire Bitcoin Optech #233'
2023-01-18-newsletter.md:title: 'Bulletin Hebdomadiare Bitcoin Optech #234'
2023-01-25-newsletter.md:title: 'Bulletin Hebdomadaire Bitcoin Optech #235'
2023-02-01-newsletter.md:title: 'Bulletin hebdomadaire Bitcoin Optech #236'
2023-02-08-newsletter.md:title: 'Bulletin Bitcoin Optech #237'
2023-02-15-newsletter.md:title: 'Bulletin hebdomadaire Bitcoin Optech #238'
2023-02-22-newsletter.md:title: 'Bulletin hebdomadaire Bitcoin Optech #239'
2023-03-01-newsletter.md:title: 'Bulletin hebdomadaire Bitcoin Optech #240'
2023-03-08-newsletter.md:title: 'Bulletin hebdomadaire Bitcoin Optech #241'
2023-03-15-newsletter.md:title: 'Bulletin hebdomadaire Bitcoin Optech #242'
2023-03-22-newsletter.md:title: 'Bulletin Bitcoin Optech #243'
2023-03-29-newsletter.md:title: 'Bulletin Hebdomadaire Bitcoin Optech #244'
2023-04-05-newsletter.md:title: 'Bulletin Hebdomadaire Bitcoin Optech #245'
2023-04-12-newsletter.md:title: 'Bulletin Hebdomadaire Bitcoin Optech #246'
2023-04-19-newsletter.md:title: 'Bulletin Hebdomadaire Bitcoin Optech #247'
2023-04-26-newsletter.md:title: 'Bulletin Hebdomadaire Bitcoin Optech #248'
2023-05-03-newsletter.md:title: 'Bulletin Hebdomadaire Bitcoin Optech #249'
2023-05-10-newsletter.md:title: 'Bulletin Hebdomadaire Bitcoin Optech #250'
2023-05-17-newsletter.md:title: 'Bulletin Hebdomadaire Optech #251'
2023-05-24-newsletter.md:title: 'Bulletin Hebdomadaire Bitcoin Optech #252'
2023-05-31-newsletter.md:title: 'Bulletin Hebdomadaire Bitcoin Optech #253'
2023-06-07-newsletter.md:title: 'Bulletin Hebdomadaire Bitcoin Optech #254'
2023-06-14-newsletter.md:title: 'Bulletin Hebdomadaire Bitcoin Optech #255'
2023-06-21-newsletter.md:title: 'Bulletin Hebdomadaire Bitcoin Optech #256'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Bulletin Hebdomadaire Bitcoin Optech" because it is a weekly newsletter.

Is there a solution for modifying the titles in batches, or is it necessary to modify each one individually?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it is easy for example with sed:
sed -i 's/Bulletin Bitcoin Optech/Bulletin Hebdomadaire Bitcoin Optech/g' *.md

I’ve opened a PR here: #1222

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help,

do you ha ve a command for auto translate in french ? 😜

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, unfortunately 😞

@Copinmalin Copinmalin marked this pull request as ready for review August 4, 2023 20:21
@murchandamus murchandamus mentioned this pull request Aug 7, 2023
Merged
@murchandamus murchandamus mentioned this pull request Aug 7, 2023
Merged
bitschmidty
bitschmidty approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@bitschmidty bitschmidty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, thank you @Copinmalin and @murchandamus !

@bitschmidty bitschmidty merged commit dabd24a into bitcoinops:master Aug 7, 2023
1 check passed
@Copinmalin Copinmalin deleted the Newsletter-257-translate-in-french branch August 9, 2023 15:55
harding pushed a commit to harding/bitcoinops.github.io that referenced this pull request Sep 27, 2024
@Copinmalin @Jluc-bitcoinfr @harding
Newsletter 257 translate in french (bitcoinops#1182)
ce0da77 

---------

Co-authored-by: Jluc-bitcoinfr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murchandamus murchandamus murchandamus left review comments

@bitschmidty bitschmidty bitschmidty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Copinmalin @bitschmidty @murchandamus @Jluc-bitcoinfr