Add setup_device function #55
Conversation
src/lib.rs
Outdated
| let devices = HWIClient::enumerate().unwrap(); | ||
| let unsupported = ["ledger", "coldcard", "jade"]; | ||
| for device in devices { | ||
| let device = device.unwrap(); |
There was a problem hiding this comment.
I'm testing with a non initialized trezor emulator, and this unwrap actually panics: hwi enumerate first result is, in fact, an error:
[{"type": "trezor", "path": "udp:127.0.0.1:21324", "label": null, "model": "trezor_t_simulator", "needs_pin_sent": false, "needs_passphrase_sent": false, "error": "Not initialized", "code": -18}]
There was a problem hiding this comment.
Ok, we need find_device function instead of enumerate for not initialized devices. I'll open a new PR to add find_device function.
I did some tests and I saw that the setup_device command does not work on emulators but only on physical devices (at least my emulator returns the error "PIN requested but no sequence was configured").
There was a problem hiding this comment.
Ok, we need find_device function instead of enumerate for not initialized devices. I'll open a new PR to add find_device function.
This would be great, thanks!
I did some tests and I saw that the setup_device command does not work on emulators but only on physical devices (at least my emulator returns the error "PIN requested but no sequence was configured").
I'm hitting the same error, I just opened bitcoin-core/HWI#646 :)
|
The code looks good, can you please squash your commits together? Also, were you able to test this with a physical trezor device? |
|
Yes, I tested on a physical device (Trezor model T) and works. |
No description provided.