-
Notifications
You must be signed in to change notification settings - Fork 37.3k
ci: Downgrade DEBUG=1 to -D_GLIBCXX_ASSERTIONS in centos task #32586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32586. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
a476e94
to
fa07953
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK fa07953
Not sure; now we wouldn't have any (non-msan, non-32 bit task) CI using |
Of course there is no right or wrong answer here, but I'd say that the libc++ debug build (msan) and glibc++ debug build (32-bit) are probably enough and redundant with this one anyway, so one could even fully remove the debug setting here. (Also, there is other, possibly more important stuff, only run in nightly CIs outside this repo, including a full gcc debug run, so based on that it should also be fine) |
In the short term, getting the CI to pass reliably again is most important imo. Adding another DEBUG run can always be considered, but shouldn't come at the cost of CI flakiness. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK fa07953 - we can followup
(edited a prior comment of mine, which said there are two libc++ debug runs in the CI. In reality there is the libc++ debug build (msan) and the glibc++ debug build (32-bit).) |
to work around #32524 (comment)
closes #32524