Skip to content

bip54: exempt genesis from coinbase checks - #2326

Open
nervana21 wants to merge 1 commit into
bitcoin:masterfrom
nervana21:bip54-skip-genesis
Open

nervana21 wants to merge 1 commit into
bitcoin:masterfrom
nervana21:bip54-skip-genesis

Conversation

@nervana21

Copy link
Copy Markdown
Contributor

The BIP54 reference implementation skips genesis when checking the new coinbase locktime and sequence rules. However this wasn't specified in the BIP.

Update the BIP to reflect that genesis is exempt from these checks.

@fametrano

Copy link
Copy Markdown
Contributor

Concept ACK. All 7 cases in bip-0054/test_vectors/coinbases.json start from the mainnet genesis block. Its coinbase has nLockTime 0 and nSequence 0xffffffff, so the rule as written makes all of them invalid. bitcoin/bitcoin#35793 also skips the check at height 0.

The timewarp rule has the same gap: at N=0 there is no TN−1, and timestamps.json also starts from genesis. One sentence could exempt genesis from both rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants