Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ux): improve the desktop shortcut #977

Conversation

bitcoin-tools
Copy link
Owner

@bitcoin-tools bitcoin-tools commented May 30, 2024

Describe the changes and your approach

Verification Checklist

  • I performed a self-review of my changes and approve them.
  • I checked of the automated test results for any irregularities.
  • I manually tested the code changes on my local environment.
  • I considered changes to the README or test docs. (Check if not applicable.)

@bitcoin-tools bitcoin-tools marked this pull request as draft May 31, 2024 02:57
@bitcoin-tools bitcoin-tools marked this pull request as draft May 31, 2024 02:57
@bitcoin-tools bitcoin-tools marked this pull request as draft May 31, 2024 02:57
@bitcoin-tools
Copy link
Owner Author

Original shortcut details:

[Desktop Entry]
Name=Bitcoin Core
Comment=Launch Bitcoin Core
Exec=sh -c 'if command -v bitcoin-qt >/dev/null 2>&1; then bitcoin-qt; else bitcoind --daemonwait; fi'
Icon=${SHORTCUT_IMAGE_FILE}
Terminal=false
StartupWMClass=Bitcoin Core
Type=Application
Categories=Application;
MimeType=application/bitcoin-paymentrequest;application/bitcoin-payment;application/bitcoin-paymentack;x-scheme-handler/bitcoin;

@bitcoin-tools
Copy link
Owner Author

bitcoin-tools commented Aug 11, 2024

New shortcut details:

[Desktop Entry]
Version=1.0
Name=Bitcoin Core
Comment=Connect to the Bitcoin P2P Network
Comment[de]=Verbinde mit dem Bitcoin peer-to-peer Netzwerk
Comment[fr]=Bitcoin, monnaie virtuelle cryptographique pair à pair
Comment[tr]=Bitcoin, eşten eşe kriptografik sanal para birimi
Exec=sh -c 'if command -v bitcoin-qt >/dev/null 2>&1; then bitcoin-qt; else bitcoind --daemonwait; fi'
Terminal=false
Type=Application
Icon=${SHORTCUT_IMAGE_FILE}
MimeType=x-scheme-handler/bitcoin;
Categories=Office;Finance;P2P;Network;Qt;
StartupWMClass=Bitcoin-qt

@bitcoin-tools bitcoin-tools marked this pull request as ready for review August 11, 2024 12:22
@bitcoin-tools bitcoin-tools merged commit 6e25a98 into master Aug 11, 2024
29 checks passed
@bitcoin-tools bitcoin-tools deleted the 833-feat-create-the-desktop-and-application-shortcuts-just-like-bitcoin-core-does branch August 11, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] - Create the desktop and application shortcuts just like Bitcoin Core does
1 participant