Replacement Cycling with split #422
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mplsgrant
force-pushed
the
2024-07-replacement-cycling-split
branch
from
713df3a
to
37f7a70
Compare
Closed
mplsgrant
force-pushed
the
2024-07-replacement-cycling-split
branch
from
37f7a70
to
5fbd51a
Compare
|
@mplsgrant curious how much has the scenario changed since I last looked? |
|
@instagibbs The mechanics have stayed exactly the same. What's changed is splitting the steps apart so we can run them out of order. |
mplsgrant
force-pushed
the
2024-07-replacement-cycling-split
branch
2 times, most recently
from
895a161
to
1309250
Compare
update rep cycle w/ better logging Add fixes, notes Author: Greg Sanders <[email protected]> Date: Wed May 29 11:30:39 2024 -0400 delint rep cycling file delint fix spelling slightly modify some log entries improve logging add sync_all() fixup spaces in logging fix indentation align alice timeout heights specify hash fixup spelling lints show mempool log funding coins add attribution make ruff happy update language
improve args log args fixup args fix keys fixup arg len is a fn add broadcast and get_raw_mempool rename broadcast_tx to broadcast_txn clean up unused variable names perform ruff format add zmq subscriber function incorporate zmq subscriber function move subscriber to class; unpack struct fixup logging setup_alice becomes setup_nodes add type hint CScript remove self.wallet indirection use blockheight in log message ruff format rc_alice comment out zmq for the moment add type hint to broadcast_txn add type hint to create_chan_state format import use dashes instead of underscores show hex of txn instead of raw CTransaction remove extra broadcast-tx flag; clarify help text improve input handling format rc_alice
mplsgrant
force-pushed
the
2024-07-replacement-cycling-split
branch
from
1309250
to
6754c5c
Compare
mplsgrant
force-pushed
the
2024-07-replacement-cycling-split
branch
from
6754c5c
to
f492fa3
Compare
|
could be nice to see if this "just works" with the new commander launcher |
|
@josibake I agree, but I'm going to leave this on the back burner for a bit, and then revisit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Need to run Replacement Cycling and allow interactivity
Solution
Split the Replacement Cycling demo into its constituent parts. Allow monitoring with zmq.
Still needs
Scenario test
Supersedes
#372