Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the serializer for ValueOrRange #188

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Fixing the serializer for ValueOrRange #188

merged 1 commit into from
Jun 25, 2024

Conversation

bjohnson5
Copy link
Contributor

Using a more specific serialization process for the ValueOrRange type. This will allow the type to be correctly serialized and deserialized.

Close #187

@bjohnson5
Copy link
Contributor Author

@carlaKC @sr-gi Let me know what you think about this. I have been using simln in another Rust project and came across this issue when serializing my activity definitions.

@sr-gi
Copy link
Member

sr-gi commented Jun 21, 2024

Nice catch! We don't use the serializer internally it went completely unnoticed.

LGTM

carlaKC
carlaKC approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@carlaKC carlaKC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@carlaKC carlaKC merged commit e369d61 into bitcoin-dev-project:main Jun 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlaKC carlaKC carlaKC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ValueOrRange Serialize Issue
3 participants
@bjohnson5 @sr-gi @carlaKC